Skip to content

Commit 5f2abda

Browse files
authored
Merge pull request #150 from ruby-no-kai/ci-fix
ci: ensure we don't push manifest list
2 parents 06fcf87 + 410f9f7 commit 5f2abda

File tree

2 files changed

+27
-12
lines changed

2 files changed

+27
-12
lines changed

.github/workflows/ci-pull-request.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@ jobs:
77
name: pr
88
runs-on: ubuntu-latest
99
steps:
10-
- uses: actions/checkout@v4
11-
- uses: ruby/setup-ruby@v1
10+
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
11+
- uses: ruby/setup-ruby@09a7688d3b55cf0e976497ff046b70949eeaccfd # v1.288.0
1212
with:
1313
ruby-version: '3.2'
1414
bundler-cache: true
1515
- name: 'Build Docker image'
16-
uses: 'docker/build-push-action@v3'
16+
uses: 'docker/build-push-action@10e90e3645eae34f1e60eeb005ba3a3d33f178e8' # v6.19.2
1717
with:
1818
context: '.'
1919
load: true

.github/workflows/ci.yml

Lines changed: 24 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,27 +12,29 @@ jobs:
1212
id-token: write
1313
runs-on: ubuntu-latest
1414
outputs:
15-
image-tag: "${{ steps.login-ecr.outputs.registry }}/rko-router:${{ github.sha }}"
15+
image-tag: "${{ steps.login-ecr.outputs.registry }}/rko-router:${{ github.sha }}-amd64"
1616
steps:
17-
- uses: actions/checkout@v4
18-
- uses: ruby/setup-ruby@v1
17+
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
18+
- uses: ruby/setup-ruby@09a7688d3b55cf0e976497ff046b70949eeaccfd # v1.288.0
1919
with:
20-
ruby-version: '3.4'
20+
ruby-version: '4.0'
2121
bundler-cache: true
22-
- uses: aws-actions/configure-aws-credentials@v4
22+
- uses: aws-actions/configure-aws-credentials@8df5847569e6427dd6c4fb1cf565c83acfa8afa7 # v6.0.0
2323
with:
2424
aws-region: "us-west-2"
2525
role-skip-session-tagging: true
2626
role-to-assume: "arn:aws:iam::005216166247:role/GhaRkoRouterDeploy"
2727
mask-aws-account-id: 'false' # only string works
2828
- id: login-ecr
29-
uses: aws-actions/amazon-ecr-login@v2
29+
uses: aws-actions/amazon-ecr-login@062b18b96a7aff071d4dc91bc00c4c1a7945b076 # v2.0.1
3030
- name: 'Build Docker image'
31-
uses: 'docker/build-push-action@v3'
31+
uses: 'docker/build-push-action@10e90e3645eae34f1e60eeb005ba3a3d33f178e8' # v6.19.2
3232
with:
3333
context: '.'
3434
load: true
3535
tags: "rko-router-test:latest,${{ steps.login-ecr.outputs.registry }}/rko-router:${{ github.sha }},${{ steps.login-ecr.outputs.registry }}/rko-router:latest"
36+
cache-from: type=gha
37+
cache-to: type=gha,mode=max
3638
- name: 'Start container for test'
3739
run: |
3840
set -x
@@ -52,11 +54,24 @@ jobs:
5254
export TARGET_HOST="http://$(docker port rko-router-dut 8080)"
5355
bundle exec rspec -fd || ( docker logs rko-router-dut; false )
5456
- name: 'Push Docker image'
55-
uses: 'docker/build-push-action@v5'
57+
uses: 'docker/build-push-action@10e90e3645eae34f1e60eeb005ba3a3d33f178e8' # v6.19.2
5658
with:
5759
context: '.'
5860
push: true
5961
tags: "${{ steps.login-ecr.outputs.registry }}/rko-router:${{ github.sha }},${{ steps.login-ecr.outputs.registry }}/rko-router:latest"
62+
cache-from: type=gha
63+
cache-to: type=gha,mode=max
64+
- name: 'Push Docker image'
65+
uses: 'docker/build-push-action@10e90e3645eae34f1e60eeb005ba3a3d33f178e8' # v6.19.2
66+
with:
67+
context: '.'
68+
push: true
69+
tags: "${{ steps.login-ecr.outputs.registry }}/rko-router:${{ github.sha }}-amd64"
70+
cache-from: type=gha
71+
cache-to: type=gha,mode=max
72+
# Lambda does not support manifest list
73+
sbom: false
74+
provenance: false
6075

6176
deploy-lambda:
6277
name: deploy-lambda
@@ -73,7 +88,7 @@ jobs:
7388
needs:
7489
- ci
7590
steps:
76-
- uses: aws-actions/configure-aws-credentials@v4
91+
- uses: aws-actions/configure-aws-credentials@8df5847569e6427dd6c4fb1cf565c83acfa8afa7 # v6.0.0
7792
with:
7893
aws-region: "us-west-2"
7994
role-skip-session-tagging: true

0 commit comments

Comments
 (0)