Add player change nickname dispatch

Author: cveneziani

app/controllers/players_controller.rb

@@ -4,14 +4,7 @@ class PlayersController < ApplicationController
   def update
     return render json: { error: "Cannot update another user" }, status: 401 if @player != current_player
 
-    @player.update(player_params)
-
-    payload = {
-      code:      "successful_player_nickname_update",
-      player_id: @player.id,
-      nickname:  @player.nickname
-    }
-
+    payload = Players::ChangeNickname.call(player: @player, nickname: params[:player][:nickname])
     ActionCable.server.broadcast "game_#{current_player.game_id}", payload
     head 200
   end
@@ -21,8 +14,4 @@ def update
   def set_player
     @player = Player.find(params[:id])
   end
-
-  def player_params
-    params.require(:player).permit(:nickname)
-  end
 end

app/dispatches/players/change_nickname.rb

@@ -0,0 +1,33 @@
+module Players
+  class ChangeNickname
+    private
+    attr_reader :nickname, :player
+
+    public
+
+    def self.call(player:, nickname:)
+      new(player: player, nickname: nickname).call
+    end
+
+    def initialize(player:, nickname:)
+      @nickname = nickname
+      @player   = player
+    end
+
+    def call
+      update_nickname
+
+      return successful_payload
+    end
+
+    private
+
+    def update_nickname
+      player.update(nickname: nickname)
+    end
+
+    def successful_payload
+      { code: "player_nickname_changed", player_id: @player.id, nickname:  @player.nickname }
+    end
+  end
+end

spec/dispatches/players/change_nickname_spec.rb

@@ -0,0 +1,21 @@
+require "rails_helper"
+
+RSpec.describe "Players::ChangeNickname", type: :dispatch do
+  subject(:dispatch)  { Players::ChangeNickname }
+  let(:game)          { Game.create! }
+  let(:player)        { Player.create!(game: game, nickname: "Rico") }
+
+  describe ".call" do
+    it 'updates player nickname' do
+      expect { dispatch.call(player: player, nickname: "Zim") }.to change { player.nickname }.from("Rico").to("Zim")
+    end
+
+    it 'returns a payload' do
+      expect(dispatch.call(player: player, nickname: "Zim")).to be_instance_of(Hash)
+    end
+
+    it "returns payload with the new nickname of the player" do
+      expect(dispatch.call(player: player, nickname: "Zim")).to include(code: 'player_nickname_changed', player_id: player.id, nickname: "Zim")
+    end
+  end
+end

spec/requests/players_spec.rb

@@ -24,7 +24,7 @@
         put "/players/#{player.id}", params: { player: { nickname: "Zim" }}
         expect(ActionCable.server).to have_received(:broadcast).with(
           anything,
-          code: 'successful_player_nickname_update', player_id: player.id, nickname: 'Zim'
+          code: 'player_nickname_changed', player_id: player.id, nickname: 'Zim'
         )
       end
     end