Add #winner and #loser associations to Game

Author: cveneziani

app/models/game.rb

@@ -7,6 +7,9 @@ class Game < ApplicationRecord
   has_many :ships,   through: :players
   has_many :words,   dependent: :destroy
 
+  has_one :loser,  -> { where(won: false ) }, class_name: 'Player'
+  has_one :winner, -> { where(won: true ) },  class_name: 'Player'
+
   def to_param
     slug
   end

app/views/games/finished.html.erb

@@ -9,13 +9,14 @@
       </div>
     </div>
     <div class="too_late">
-      <% if @game.players.include?(current_player) && current_player.won %>
+      <% case current_player
+         when @game.winner %>
         <h1>Game Finished, Congratulations! You WON!</h1>
         <p>
           You're the master of the <strong><%= @game.name %></strong> room
           where you defeated <strong><%= @opponent.nickname %></strong>.
         </p>
-      <% elsif @game.players.include?(current_player) %>
+      <% when @game.loser %>
         <h1>Game Finished, You LOSE!</h1>
         <p>
           Today wasn't a good day for you in the <strong><%= @game.name %></strong> room.

spec/models/game_spec.rb

@@ -0,0 +1,8 @@
+require "rails_helper"
+
+RSpec.describe "Game", type: :model do
+  subject(:game) { Game.new }
+
+  it { is_expected.to have_one(:loser).class_name(Player).conditions(won: false) }
+  it { is_expected.to have_one(:winner).class_name(Player).conditions(won: true) }
+end

spec/requests/games_spec.rb

@@ -117,28 +117,28 @@
         zim.update!(game: game, won: false)
       end
 
-      it 'displays that game is finished' do
+      it 'tells that the game is finished' do
         get "/games/#{game.to_param}"
         expect(response.body).to include("finished")
       end
 
-      context 'wen signed in player won the game' do
+      context 'when the signed-in player won the game' do
         before :each do
           allow_any_instance_of(ApplicationController).to receive(:current_player).and_return(rico)
         end
 
-        it 'displays that user won the game' do
+        it 'tells the user that he won' do
           get "/games/#{game.to_param}"
           expect(response.body).to include("WON")
         end
       end
 
-      context 'when signed in player lost the game' do
+      context 'when the signed-in player lost the game' do
         before :each do
           allow_any_instance_of(ApplicationController).to receive(:current_player).and_return(zim)
         end
 
-        it 'displays that user lost the game' do
+        it 'tells the user that he lost' do
           get "/games/#{game.to_param}"
           expect(response.body).to include("LOSE")
         end