Disable defense on finihed game

Author: cveneziani

app/assets/javascripts/battletype/logs.js

@@ -38,6 +38,7 @@
       "already_destroyed":    "Ship is already destroyed!",
       "bomb_already_dropped": "Bomb already dropped",
       "player_ship":          "It's your own ship!",
+      "not_running":          "Game is not running!",
       "ship_not_found":       "Ship not found",
       "wrong_case":           "Words are case sensitive"
     }

app/dispatches/defenses/launch.rb

@@ -32,7 +32,11 @@ def shot_down_ship
     end
 
     def failed_payload
-      { code: 'failed_defense', player_id: player.id, word: word, error_codes: defense.errors[:word] }
+      { code: 'failed_defense', player_id: player.id, word: word, error_codes: error_codes }
+    end
+
+    def error_codes
+      defense.errors.messages.values.flatten
     end
 
     def successful_payload

app/models/defense.rb

@@ -1,7 +1,12 @@
 class Defense
   include ActiveModel::Validations
 
-  validate :ship_exists, :matching_case_sensitive, :not_matching_own_ship, :ship_not_destroyed_yet, :mission_not_accomplished_yet
+  validate  :game_running,
+            :ship_exists,
+            :matching_case_sensitive,
+            :not_matching_own_ship,
+            :ship_not_destroyed_yet,
+            :mission_not_accomplished_yet
 
   private
   attr_reader :player, :perfect_typing, :word
@@ -35,6 +40,12 @@ def unlocked_strike
 
   private
 
+  def game_running
+    unless player.game.state == 'running'
+      errors.add(:game, "not_running")
+    end
+  end
+
   def ship_not_destroyed_yet
     if ship&.state == 'destroyed'
       errors.add(:word, "already_destroyed")

spec/dispatches/defenses/launch_spec.rb

@@ -3,7 +3,7 @@
 RSpec.describe "Defenses::Launch", type: :dispatch do
   subject(:dispatch)  { Defenses::Launch }
 
-  let(:game)          { Game.create! }
+  let(:game)          { Game.create!(state: 'running') }
   let(:attacker)      { Player.create!(game: game) }
   let(:attacker_ship) { attacker.ships.last }
   let(:attacker_word) { Word.create!(value: 'attacker', game: game) }

spec/models/defense_spec.rb

@@ -3,7 +3,7 @@
 RSpec.describe "Defense", type: :model do
   subject(:defense)     { Defense.new(player: player, word: word, perfect_typing: perfect_typing) }
 
-  let(:game)            { Game.create! }
+  let(:game)            { Game.create!(state: 'running') }
   let(:attacker)        { Player.create!(game: game) }
   let(:attacker_word)   { Word.create!(value: 'HaCkeR', game: game) }
   let(:perfect_typing)  { '1' }
@@ -162,5 +162,15 @@
         expect(defense.valid?).to eq(true)
       end
     end
+
+    context 'when game is finished' do
+      before :each do
+        game.update(state: 'finished')
+      end
+
+      it 'returns false' do
+        expect(defense.valid?).to eq(false)
+      end
+    end
   end
 end

spec/requests/defenses_spec.rb

@@ -1,7 +1,7 @@
 require "rails_helper"
 
 RSpec.describe "Defenses", type: :request do
-  let(:game)      { Game.create!(name: 'Starship Battle') }
+  let(:game)      { Game.create!(name: 'Starship Battle', state: 'running') }
   let(:attacker)  { game.players.create! }
   let(:player)    { game.players.create! }
 
@@ -201,5 +201,32 @@
         )
       end
     end
+
+    context 'when game is finished' do
+      before :each do
+        attacker_word = Word.create!(value: 'finished')
+        attacker.ships.create!(word: attacker_word)
+        game.update(state: 'finished')
+      end
+
+      it "returns 200 HTTP status" do
+        post "/defenses", params: { word: 'finished', perfect_typing: '0' }
+        expect(response).to have_http_status(200)
+      end
+
+      it 'broadcasts a failed defense payload' do
+        allow(ActionCable.server).to receive(:broadcast)
+        post "/defenses", params: { word: 'finished' }
+        expect(ActionCable.server).to have_received(:broadcast).with(
+          anything,
+          {
+            code:        'failed_defense',
+            player_id:   player.id,
+            word:        'finished',
+            error_codes: ['not_running']
+          }
+        )
+      end
+    end
   end
 end