[hysteria] Cleanup player update

Author: cveneziani

app/controllers/players_controller.rb

@@ -2,13 +2,14 @@ class PlayersController < ApplicationController
   before_action :set_player
 
   def update
-    return render json: {error: "Cannot update another user"}, status: 401 if @player != current_player
+    return render json: { error: "Cannot update another user" }, status: 401 if @player != current_player
 
     @player.update(player_params)
-    render json: {status: :ok}, status: 200
+    render json: { status: :ok }, status: 200
   end
 
   private
+
   def set_player
     @player = Player.find(params[:id])
   end

app/views/games/show.html.erb

@@ -19,7 +19,6 @@
         <li class="life_bar"><%= render "games/hud/life" %></li>
         <li class="life_bar"><%= render "games/hud/life" %></li>
       </ul>
-      <!-- <h1 class="player">Casimir</h1> -->
       <div id="current_player" data-player-id="<%= current_player.id %>" data-player-nickname="<%= current_player.nickname %>"></div>
       <%= form_for(current_player, url: player_path(current_player), class: "player") do |f|%>
         <%= f.text_field :nickname, id: 'current_player_nickname' %>

spec/requests/players_spec.rb

@@ -1,28 +1,29 @@
 require "rails_helper"
 
 RSpec.describe "Players", type: :request do
-  let(:player)          { Player.create!(nickname: "Rico") }
+  let(:player) { Player.create!(nickname: "Rico") }
 
   describe "PUT update" do
     context 'update current_player' do
       before :each do
         allow_any_instance_of(ApplicationController).to receive(:current_player).and_return(player)
+        put "/players/#{player.id}", params: { player: { nickname: "Zim" }}
       end
 
-      before { put "/players/#{player.id}", params: {player: {nickname: "Zim"}} }
       it { expect(response).to have_http_status(200) }
       it { expect(player.reload.nickname).to eq("Zim") }
     end
-  end
 
-  context 'update another player' do
-    let(:other_player) { Player.create!(nickname: "Carmen") }
-    before :each do
-      allow_any_instance_of(ApplicationController).to receive(:current_player).and_return(other_player)
-    end
+    context 'update another player' do
+      let(:other_player) { Player.create!(nickname: "Carmen") }
+
+      before :each do
+        allow_any_instance_of(ApplicationController).to receive(:current_player).and_return(other_player)
+        put "/players/#{player.id}", params: { player: { nickname: "Ace" }}
+      end
 
-    before { put "/players/#{player.id}", params: {player: {nickname: "Ace"}} }
-    it { expect(response).to have_http_status(401) }
-    it { expect(player.reload.nickname).to eq("Rico") }
+      it { expect(response).to have_http_status(401) }
+      it { expect(player.reload.nickname).to eq("Rico") }
+    end
   end
-end
+end