Skip to content

Commit 8f85bf5

Browse files
committed
🚑️ Correct circular reference
- backwards compatibility is hard, folks
1 parent 3e01336 commit 8f85bf5

File tree

4 files changed

+2
-12
lines changed

4 files changed

+2
-12
lines changed

.simplecov

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ if RUN_COVERAGE
2626
formatter SimpleCov::Formatter::HTMLFormatter
2727
end
2828

29-
minimum_coverage(62)
29+
minimum_coverage(61)
3030
end
3131
else
3232
puts "Not running coverage on #{RUBY_ENGINE} #{RUBY_VERSION}"

lib/oauth/cli.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
# frozen_string_literal: true
22

33
require "oauth/tty"
4-
require "oauth/tty/cli"
54

65
# Backwards compatibility hack.
76
# TODO: Remove with April 2023 release of 2.0 release of oauth gem

lib/oauth/tty.rb

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,6 @@
2121
require_relative "tty/commands/sign_command"
2222
require_relative "tty/commands/version_command"
2323

24-
# A gem was released in 2011 which was a rudimentary commands for the oauth gem,
25-
# thus it occupies the name in RubyGems.org.
26-
# This library was originally written as part of the oauth gem, in 2016, as OAuth::TTY.
27-
# This gem is named oauth-tty, but intends to have backwards compatibility with oauth gem v1.0.x.
28-
# Now that it is being extracted there is a name conflict.
29-
#
30-
# oauth-cli is a backwards compatibility loader hook for bundler
31-
# TODO: Remove with April 2023 release of 2.0 release of oauth gem
32-
require "oauth/cli"
33-
3424
module OAuth
3525
# The namespace of this gem
3626
module TTY

test/backwards_compatibility_test.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
require_relative "test_helper"
44

5+
require "oauth/cli"
56
class BackwardsCompatibilityTest < Minitest::Test
67
def test_backwards_compat
78
assert_equal OAuth::CLI, OAuth::TTY::CLI

0 commit comments

Comments
 (0)