Skip to content

Commit 9e2b584

Browse files
committed
🐛 RUBY_VERSION depends on rake release so remove from gemspec
Signed-off-by: Peter Boling <[email protected]>
1 parent be296cb commit 9e2b584

File tree

2 files changed

+22
-22
lines changed

2 files changed

+22
-22
lines changed

Gemfile

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,25 @@
11
source "https://rubygems.org"
22

33
gemspec
4+
5+
ruby_version = Gem::Version.new(RUBY_VERSION)
6+
minimum_version = ->(version) { ruby_version >= Gem::Version.new(version) && RUBY_ENGINE == "ruby" }
7+
linting = minimum_version.call("2.6")
8+
coverage = minimum_version.call("2.6")
9+
debug = minimum_version.call("2.4")
10+
if linting
11+
gem "danger", "~> 8.4"
12+
gem "rubocop", "~> 1.22"
13+
gem "rubocop-faker", "~> 1.1"
14+
gem "rubocop-md", "~> 1.0"
15+
gem "rubocop-minitest", "~> 0.15"
16+
gem "rubocop-packaging", "~> 0.5"
17+
gem "rubocop-performance", "~> 1.11"
18+
gem "rubocop-rake", "~> 0.6"
19+
gem "rubocop-thread_safety", "~> 0.4"
20+
end
21+
if coverage
22+
gem "simplecov", "~> 0.21"
23+
gem "simplecov-cobertura", "~> 1.4"
24+
end
25+
gem "byebug", "~> 11.1" if debug

oauth.gemspec

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,7 @@ Gem::Specification.new do |spec|
2929
# This gem will work with Ruby 2.0 or greater...
3030
spec.required_ruby_version = ">= 2.0"
3131

32-
ruby_version = Gem::Version.new(RUBY_VERSION)
33-
minimum_version = ->(version) { ruby_version >= Gem::Version.new(version) && RUBY_ENGINE == "ruby" }
34-
linting = minimum_version.call("2.6")
35-
coverage = minimum_version.call("2.6")
36-
debug = minimum_version.call("2.4")
37-
3832
spec.add_development_dependency("actionpack", ">= 5.0")
39-
spec.add_development_dependency("byebug", "~> 11.1") if debug
4033
spec.add_development_dependency("curb")
4134
spec.add_development_dependency("em-http-request", "~> 1.1.7")
4235
spec.add_development_dependency("iconv")
@@ -46,21 +39,6 @@ Gem::Specification.new do |spec|
4639
spec.add_development_dependency("rack-test")
4740
spec.add_development_dependency("rake", "~> 13.0")
4841
spec.add_development_dependency("rest-client")
49-
if linting
50-
spec.add_development_dependency("rubocop", "~> 1.22")
51-
spec.add_development_dependency("rubocop-faker", "~> 1.1")
52-
spec.add_development_dependency("rubocop-md", "~> 1.0")
53-
spec.add_development_dependency("rubocop-minitest", "~> 0.15")
54-
spec.add_development_dependency("rubocop-packaging", "~> 0.5")
55-
spec.add_development_dependency("rubocop-performance", "~> 1.11")
56-
spec.add_development_dependency("rubocop-rake", "~> 0.6")
57-
spec.add_development_dependency("rubocop-thread_safety", "~> 0.4")
58-
spec.add_development_dependency("danger", "~> 8.4")
59-
end
60-
if coverage
61-
spec.add_development_dependency("simplecov", "~> 0.21")
62-
spec.add_development_dependency("simplecov-cobertura", "~> 1.4")
63-
end
6442
spec.add_development_dependency("typhoeus", ">= 0.1.13")
6543
spec.add_development_dependency("webmock", "<= 3.14.0")
6644
end

0 commit comments

Comments
 (0)