Skip to content

Commit a0bf3a2

Browse files
committed
💚 cgi mostly removed from ruby-head, so add cgi as dev dependency
- in support of vcr: vcr/vcr#1057
1 parent 625aefb commit a0bf3a2

File tree

4 files changed

+7
-1
lines changed

4 files changed

+7
-1
lines changed

.rubocop_gradual.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
"lib/oauth/tokens/consumer_token.rb:3696415131": [
3535
[9, 5, 155, "Style/ClassMethodsDefinitions: Use `class << self` to define a class method.", 349576019]
3636
],
37-
"oauth.gemspec:1987611209": [
37+
"oauth.gemspec:1419764957": [
3838
[133, 3, 56, "Gemspec/DependencyVersion: Dependency version specification is required.", 644892567],
3939
[153, 3, 40, "Gemspec/DependencyVersion: Dependency version specification is required.", 2300588954],
4040
[155, 3, 44, "Gemspec/DependencyVersion: Dependency version specification is required.", 1905290578],

Appraisals

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ end
3030
# Used for head (nightly) releases of ruby, truffleruby, and jruby.
3131
# Split into discrete appraisals if one of them needs a dependency locked discretely.
3232
appraise "head" do
33+
# Why is gem "cgi" here? See: https://github.com/vcr/vcr/issues/1057
34+
gem "cgi", ">= 0.5"
3335
gem "benchmark", "~> 0.4", ">= 0.4.1"
3436
eval_gemfile "modular/x_std_libs.gemfile"
3537
end

gemfiles/head.gemfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
source "https://rubygems.org"
44

55
gem "oauth-tty", branch: "main", git: "https://github.com/ruby-oauth/oauth-tty"
6+
gem "cgi", ">= 0.5"
67
gem "benchmark", "~> 0.4", ">= 0.4.1"
78

89
gemspec path: "../"

oauth.gemspec

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,9 @@ Thanks, |7eter l-|. l3oling
202202
# | # ./spec/spec_helper.rb:8:in `<top (required)>'
203203
# So that's why we need backports.
204204
spec.add_development_dependency("backports", "~> 3.25", ">= 3.25.1") # ruby >= 0
205+
# In Ruby 3.5 (HEAD) the CGI library has been pared down, so we also need to depend on gem "cgi" for ruby@head
206+
# This is done in the "head" appraisal.
207+
# See: https://github.com/vcr/vcr/issues/1057
205208
spec.add_development_dependency("vcr", ">= 4") # 6.0 claims to support ruby >= 2.3, but fails on ruby 2.4
206209
spec.add_development_dependency("webmock", ">= 3") # Last version to support ruby >= 2.3
207210
end

0 commit comments

Comments
 (0)