✅ Fix tests

Author: pboling

.rubocop_gradual.lock

@@ -97,8 +97,7 @@
   "spec/oauth2/version_spec.rb:1001406821": [
     [3, 1, 30, "RSpec/SpecFilePathFormat: Spec path should end with `o_auth2/version*_spec.rb`.", 1099517182]
   ],
-  "spec/oauth2_spec.rb:438638294": [
-    [3, 1, 21, "RSpec/SpecFilePathFormat: Spec path should end with `o_auth2*_spec.rb`.", 3359091140],
-    [5, 68, 2, "RSpec/BeEq: Prefer `be` over `eq`.", 5860785]
+  "spec/oauth2_spec.rb:245212644": [
+    [3, 1, 21, "RSpec/SpecFilePathFormat: Spec path should end with `o_auth2*_spec.rb`.", 3359091140]
   ]
 }

lib/oauth2/client.rb

@@ -449,7 +449,7 @@ def build_access_token_legacy(response, access_token_opts, extract_access_token)
     end
 
     def oauth_debug_logging(builder)
-      builder.response(:logger, options[:logger], bodies: true) if OAUTH_DEBUG
+      builder.response(:logger, options[:logger], bodies: true) if OAuth2::OAUTH_DEBUG
     end
   end
 end

spec/oauth2/access_token_spec.rb

@@ -51,7 +51,12 @@
       end
 
       before do
-        stub_const("OAuth2::OAUTH_DEBUG", true)
+        @original_setw = OAuth2.config.silence_extra_tokens_warning
+        OAuth2.config.silence_extra_tokens_warning = false
+      end
+
+      after do
+        OAuth2.config.silence_extra_tokens_warning = @original_setw
       end
 
       it "warns on STDERR" do
@@ -94,7 +99,12 @@
       end
 
       before do
-        stub_const("OAuth2::OAUTH_DEBUG", true)
+        @original_setw = OAuth2.config.silence_extra_tokens_warning
+        OAuth2.config.silence_extra_tokens_warning = false
+      end
+
+      after do
+        OAuth2.config.silence_extra_tokens_warning = @original_setw
       end
 
       let(:hash) do

spec/oauth2/client_spec.rb

@@ -356,8 +356,7 @@
       expect(response.headers).to eq("Content-Type" => "text/awesome")
     end
 
-    context "with ENV" do
-      context "when OAUTH_DEBUG=true" do
+    context "when silence_extra_tokens_warning=false" do
         before do
           stub_const("OAuth2::OAUTH_DEBUG", true)
         end
@@ -374,7 +373,6 @@
           expect(output).to include(*logs)
         end
       end
-    end
 
     it "posts a body" do
       response = subject.request(:post, "/reflect", body: "foo=bar")

spec/oauth2_spec.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
 RSpec.describe OAuth2 do
-  it "has a default config for silence_extra_tokens_warning" do
-    expect(described_class.config.silence_extra_tokens_warning).to eq(true)
+  it "silence_extra_tokens_warning default is opposite of OAUTH_DEBUG" do
+    expect(described_class.config.silence_extra_tokens_warning).to eq(!OAuth2::OAUTH_DEBUG)
   end
 
   describe ".configure" do