Skip to content

Commit 3ad1a94

Browse files
committed
💚 Fix specs
- unstub spec for JRuby
1 parent 17c3157 commit 3ad1a94

File tree

3 files changed

+10
-14
lines changed

3 files changed

+10
-14
lines changed

.rubocop_gradual.lock

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
[69, 15, 38, "RSpec/ContextWording: Context description should match /^when\\b/, /^with\\b/, or /^without\\b/.", 1480816240],
4949
[79, 13, 23, "RSpec/ContextWording: Context description should match /^when\\b/, /^with\\b/, or /^without\\b/.", 2314399065]
5050
],
51-
"spec/oauth2/client_spec.rb:348683155": [
51+
"spec/oauth2/client_spec.rb:2985507284": [
5252
[6, 1, 29, "RSpec/SpecFilePathFormat: Spec path should end with `o_auth2/client*_spec.rb`.", 439549885],
5353
[175, 7, 492, "RSpec/NoExpectationExample: No expectation found in this example.", 1272021224],
5454
[194, 7, 592, "RSpec/NoExpectationExample: No expectation found in this example.", 3428877205],
@@ -66,15 +66,15 @@
6666
[1082, 11, 82, "Style/ClassMethodsDefinitions: Use `class << self` to define a class method.", 1524553529],
6767
[1162, 17, 12, "RSpec/ContextWording: Context description should match /^when\\b/, /^with\\b/, or /^without\\b/.", 664794325]
6868
],
69-
"spec/oauth2/error_spec.rb:1209122273": [
69+
"spec/oauth2/error_spec.rb:1648148825": [
7070
[23, 1, 28, "RSpec/SpecFilePathFormat: Spec path should end with `o_auth2/error*_spec.rb`.", 3385870076],
71-
[93, 11, 534, "RSpec/NoExpectationExample: No expectation found in this example.", 3347340910],
72-
[109, 11, 210, "RSpec/NoExpectationExample: No expectation found in this example.", 3948582233],
73-
[241, 11, 534, "RSpec/NoExpectationExample: No expectation found in this example.", 3347340910],
74-
[257, 11, 210, "RSpec/NoExpectationExample: No expectation found in this example.", 3948582233],
75-
[315, 11, 534, "RSpec/NoExpectationExample: No expectation found in this example.", 3347340910],
76-
[376, 11, 534, "RSpec/NoExpectationExample: No expectation found in this example.", 3347340910],
77-
[392, 11, 210, "RSpec/NoExpectationExample: No expectation found in this example.", 3948582233]
71+
[93, 11, 332, "RSpec/NoExpectationExample: No expectation found in this example.", 970111147],
72+
[105, 11, 210, "RSpec/NoExpectationExample: No expectation found in this example.", 3948582233],
73+
[237, 11, 534, "RSpec/NoExpectationExample: No expectation found in this example.", 3347340910],
74+
[253, 11, 210, "RSpec/NoExpectationExample: No expectation found in this example.", 3948582233],
75+
[311, 11, 534, "RSpec/NoExpectationExample: No expectation found in this example.", 3347340910],
76+
[372, 11, 534, "RSpec/NoExpectationExample: No expectation found in this example.", 3347340910],
77+
[388, 11, 210, "RSpec/NoExpectationExample: No expectation found in this example.", 3948582233]
7878
],
7979
"spec/oauth2/response_spec.rb:3742350944": [
8080
[3, 1, 31, "RSpec/SpecFilePathFormat: Spec path should end with `o_auth2/response*_spec.rb`.", 3190869319],

spec/oauth2/client_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -922,7 +922,7 @@
922922
let(:body) { "BLOOP" }
923923

924924
it "raises error" do
925-
block_is_expected { get_token }.to raise_error(JSON::ParserError, /unexpected character: 'BLOOP'/)
925+
block_is_expected { get_token }.to raise_error(JSON::ParserError, /unexpected.*'BLOOP'/)
926926
end
927927

928928
context "when extract_access_token raises an exception" do

spec/oauth2/error_spec.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,11 +91,7 @@ def to_str
9191
end
9292

9393
it "replaces them" do
94-
# The skip can be removed once support for < 2.1 is dropped.
95-
encoding = {reason: "encode/scrub only works as of Ruby 2.1"}
96-
skip_for(encoding.merge(engine: "jruby"))
9794
# See https://bibwild.wordpress.com/2013/03/12/removing-illegal-bytes-for-encoding-in-ruby-1-9-strings/
98-
9995
raise "Invalid characters not replaced" unless subject.message.include?("� invalid �")
10096
# This will fail if {:invalid => replace} is not passed into `encode`
10197
end

0 commit comments

Comments
 (0)