Skip to content

Commit a16082b

Browse files
committed
💚 cgi mostly removed from ruby-head, so add cgi as dev dependency
- in support of vcr: vcr/vcr#1057
1 parent ebbf305 commit a16082b

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

Appraisals

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ end
3030
# Used for head (nightly) releases of ruby, truffleruby, and jruby.
3131
# Split into discrete appraisals if one of them needs a dependency locked discretely.
3232
appraise "head" do
33+
# Why is gem "cgi" here? See: https://github.com/vcr/vcr/issues/1057
34+
gem "cgi", ">= 0.5"
3335
gem "benchmark", "~> 0.4", ">= 0.4.1"
3436
eval_gemfile "modular/runtime_heads.gemfile"
3537
end

gemfiles/head.gemfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
source "https://rubygems.org"
44

5+
gem "cgi", ">= 0.5"
56
gem "benchmark", "~> 0.4", ">= 0.4.1"
67

78
gemspec path: "../"

oauth2.gemspec

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,9 @@ Thanks, @pboling / @galtzo
198198
# | # ./spec/spec_helper.rb:8:in `<top (required)>'
199199
# So that's why we need backports.
200200
spec.add_development_dependency("backports", "~> 3.25", ">= 3.25.1") # ruby >= 0
201-
spec.add_development_dependency("vcr", ">= 4") # 6.0 claims to support ruby >= 2.3, but fails on ruby 2.4
202-
spec.add_development_dependency("webmock", ">= 3") # Last version to support ruby >= 2.3
201+
# In Ruby 3.5 (HEAD) the CGI library has been pared down, so we also need to depend on gem "cgi" for ruby@head
202+
# This is done in the "head" appraisal.
203+
# See: https://github.com/vcr/vcr/issues/1057
204+
spec.add_development_dependency("vcr", ">= 4") # 6.0 claims to support ruby >= 2.3, but fails on ruby 2.4
205+
spec.add_development_dependency("webmock", ">= 3") # Last version to support ruby >= 2.3
203206
end

0 commit comments

Comments
 (0)