♻️ Rafactor for improved thread-safety (iv)

pboling · pboling · commit d1679b668396 · 2025-05-21T22:09:56.000+07:00
- extensions are per-class
diff --git a/.github/workflows/ancient.yml b/.github/workflows/ancient.yml
@@ -37,26 +37,26 @@ jobs:
           # Ruby 2.3
           - ruby: "ruby-2.3"
             appraisal: "ruby-2-3"
-            exec_cmd: "rake test"
+            exec_cmd: "rspec spec/snaky_hash/serializer_spec.rb:13"
             gemfile: "Appraisal.root"
             rubygems: "3.3.27"
             bundler: "2.3.27"
 
-          # Ruby 2.4
-          - ruby: "ruby-2.4"
-            appraisal: "ruby-2-4"
-            exec_cmd: "rake test"
-            gemfile: "Appraisal.root"
-            rubygems: "3.3.27"
-            bundler: "2.3.27"
-
-          # Ruby 2.5
-          - ruby: "ruby-2.5"
-            appraisal: "ruby-2-5"
-            exec_cmd: "rake test"
-            gemfile: "Appraisal.root"
-            rubygems: "3.3.27"
-            bundler: "2.3.27"
+#          # Ruby 2.4
+#          - ruby: "ruby-2.4"
+#            appraisal: "ruby-2-4"
+#            exec_cmd: "rake test"
+#            gemfile: "Appraisal.root"
+#            rubygems: "3.3.27"
+#            bundler: "2.3.27"
+#
+#          # Ruby 2.5
+#          - ruby: "ruby-2.5"
+#            appraisal: "ruby-2-5"
+#            exec_cmd: "rake test"
+#            gemfile: "Appraisal.root"
+#            rubygems: "3.3.27"
+#            bundler: "2.3.27"
 
     steps:
       - name: Checkout
diff --git a/doc/SnakyHash.html b/doc/SnakyHash.html
@@ -123,7 +123,7 @@ <h2>Overview</h2><div class="docstring">
 </div>
 
       <div id="footer">
-  Generated on Wed May 21 21:33:37 2025 by
+  Generated on Wed May 21 22:09:23 2025 by
   <a href="https://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
   0.9.37 (ruby-3.4.3).
 </div>
diff --git a/doc/SnakyHash/Error.html b/doc/SnakyHash/Error.html
@@ -114,7 +114,7 @@
 </div>
 
       <div id="footer">
-  Generated on Wed May 21 21:33:37 2025 by
+  Generated on Wed May 21 22:09:23 2025 by
   <a href="https://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
   0.9.37 (ruby-3.4.3).
 </div>
diff --git a/doc/SnakyHash/Extensions.html b/doc/SnakyHash/Extensions.html
@@ -446,7 +446,7 @@ <h3 class="signature " id="run-instance_method">
 </div>
 
       <div id="footer">
-  Generated on Wed May 21 21:33:37 2025 by
+  Generated on Wed May 21 22:09:23 2025 by
   <a href="https://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
   0.9.37 (ruby-3.4.3).
 </div>
diff --git a/doc/SnakyHash/Serializer.html b/doc/SnakyHash/Serializer.html
@@ -229,7 +229,7 @@ <h3 class="signature first" id="extended-class_method">
   <span class='id identifier rubyid_base'>base</span><span class='period'>.</span><span class='id identifier rubyid_extend'>extend</span><span class='lparen'>(</span><span class='id identifier rubyid_extended_module'>extended_module</span><span class='rparen'>)</span>
   <span class='comment'># :nocov:
 </span>  <span class='comment'># This will be run in CI on Ruby 2.3, but we only collect coverage from current Ruby
-</span>  <span class='kw'>unless</span> <span class='const'>VersionGem</span><span class='op'>::</span><span class='const'>Ruby</span><span class='period'>.</span><span class='id identifier rubyid_gte_minimum_version?'>gte_minimum_version?</span><span class='lparen'>(</span><span class='tstring'><span class='tstring_beg'>&quot;</span><span class='tstring_content'>2.4</span><span class='tstring_end'>&quot;</span></span><span class='rparen'>)</span>
+</span>  <span class='kw'>unless</span> <span class='id identifier rubyid_base'>base</span><span class='period'>.</span><span class='id identifier rubyid_instance_methods'>instance_methods</span><span class='period'>.</span><span class='id identifier rubyid_include?'>include?</span><span class='lparen'>(</span><span class='symbol'>:transform_values</span><span class='rparen'>)</span>
     <span class='id identifier rubyid_base'>base</span><span class='period'>.</span><span class='id identifier rubyid_include'>include</span><span class='lparen'>(</span><span class='const'><span class='object_link'><a href="Serializer/BackportedInstanceMethods.html" title="SnakyHash::Serializer::BackportedInstanceMethods (module)">BackportedInstanceMethods</a></span></span><span class='rparen'>)</span>
   <span class='kw'>end</span>
   <span class='comment'># :nocov:
@@ -316,7 +316,7 @@ <h3 class="signature " id="load-instance_method">
 </div>
 
       <div id="footer">
-  Generated on Wed May 21 21:33:37 2025 by
+  Generated on Wed May 21 22:09:23 2025 by
   <a href="https://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
   0.9.37 (ruby-3.4.3).
 </div>
diff --git a/doc/SnakyHash/Serializer/BackportedInstanceMethods.html b/doc/SnakyHash/Serializer/BackportedInstanceMethods.html
@@ -190,7 +190,7 @@ <h3 class="signature first" id="transform_values-instance_method">
 </div>
 
       <div id="footer">
-  Generated on Wed May 21 21:33:37 2025 by
+  Generated on Wed May 21 22:09:23 2025 by
   <a href="https://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
   0.9.37 (ruby-3.4.3).
 </div>
diff --git a/doc/SnakyHash/Serializer/Modulizer.html b/doc/SnakyHash/Serializer/Modulizer.html
@@ -189,7 +189,7 @@ <h3 class="signature first" id="to_extended_mod-class_method">
 </div>
 
       <div id="footer">
-  Generated on Wed May 21 21:33:37 2025 by
+  Generated on Wed May 21 22:09:23 2025 by
   <a href="https://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
   0.9.37 (ruby-3.4.3).
 </div>
diff --git a/doc/SnakyHash/Snake.html b/doc/SnakyHash/Snake.html
@@ -275,7 +275,7 @@ <h3 class="signature first" id="included-instance_method">
 </div>
 
       <div id="footer">
-  Generated on Wed May 21 21:33:37 2025 by
+  Generated on Wed May 21 22:09:23 2025 by
   <a href="https://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
   0.9.37 (ruby-3.4.3).
 </div>
diff --git a/doc/SnakyHash/Snake/SnakyModulizer.html b/doc/SnakyHash/Snake/SnakyModulizer.html
@@ -261,7 +261,7 @@ <h3 class="signature first" id="to_mod-class_method">
 </div>
 
       <div id="footer">
-  Generated on Wed May 21 21:33:37 2025 by
+  Generated on Wed May 21 22:09:23 2025 by
   <a href="https://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
   0.9.37 (ruby-3.4.3).
 </div>
diff --git a/doc/SnakyHash/StringKeyed.html b/doc/SnakyHash/StringKeyed.html
@@ -130,7 +130,7 @@ <h2>Overview</h2><div class="docstring">
 </div>
 
       <div id="footer">
-  Generated on Wed May 21 21:33:37 2025 by
+  Generated on Wed May 21 22:09:23 2025 by
   <a href="https://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
   0.9.37 (ruby-3.4.3).
 </div>
diff --git a/doc/SnakyHash/SymbolKeyed.html b/doc/SnakyHash/SymbolKeyed.html
@@ -130,7 +130,7 @@ <h2>Overview</h2><div class="docstring">
 </div>
 
       <div id="footer">
-  Generated on Wed May 21 21:33:37 2025 by
+  Generated on Wed May 21 22:09:23 2025 by
   <a href="https://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
   0.9.37 (ruby-3.4.3).
 </div>
diff --git a/doc/SnakyHash/Version.html b/doc/SnakyHash/Version.html
@@ -111,7 +111,7 @@ <h2>
 </div>
 
       <div id="footer">
-  Generated on Wed May 21 21:33:37 2025 by
+  Generated on Wed May 21 22:09:23 2025 by
   <a href="https://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
   0.9.37 (ruby-3.4.3).
 </div>
diff --git a/doc/_index.html b/doc/_index.html
@@ -214,7 +214,7 @@ <h2>Namespace Listing A-Z</h2>
 </div>
 
       <div id="footer">
-  Generated on Wed May 21 21:33:37 2025 by
+  Generated on Wed May 21 22:09:23 2025 by
   <a href="https://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
   0.9.37 (ruby-3.4.3).
 </div>
diff --git a/doc/file.CHANGELOG.html b/doc/file.CHANGELOG.html
@@ -137,7 +137,7 @@ <h3 id="added-4">Added</h3>
 </div></div>
 
       <div id="footer">
-  Generated on Wed May 21 21:33:37 2025 by
+  Generated on Wed May 21 22:09:23 2025 by
   <a href="https://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
   0.9.37 (ruby-3.4.3).
 </div>
diff --git a/doc/file.CODE_OF_CONDUCT.html b/doc/file.CODE_OF_CONDUCT.html
@@ -192,7 +192,7 @@ <h2 id="attribution">Attribution</h2>
 </div></div>
 
       <div id="footer">
-  Generated on Wed May 21 21:33:37 2025 by
+  Generated on Wed May 21 22:09:23 2025 by
   <a href="https://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
   0.9.37 (ruby-3.4.3).
 </div>
diff --git a/doc/file.CONTRIBUTING.html b/doc/file.CONTRIBUTING.html
@@ -195,7 +195,7 @@ <h3 id="to-release-a-new-version">To release a new version:</h3>
 </div></div>
 
       <div id="footer">
-  Generated on Wed May 21 21:33:37 2025 by
+  Generated on Wed May 21 22:09:23 2025 by
   <a href="https://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
   0.9.37 (ruby-3.4.3).
 </div>
diff --git a/doc/file.LICENSE.html b/doc/file.LICENSE.html
@@ -60,7 +60,7 @@
       <div id="content"><div id='filecontents'>The MIT License (MIT)<br><br>Copyright (c) 2022, 2025 Peter Boling<br><br>Permission is hereby granted, free of charge, to any person obtaining a copy<br>of this software and associated documentation files (the "Software"), to deal<br>in the Software without restriction, including without limitation the rights<br>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell<br>copies of the Software, and to permit persons to whom the Software is<br>furnished to do so, subject to the following conditions:<br><br>The above copyright notice and this permission notice shall be included in<br>all copies or substantial portions of the Software.<br><br>THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR<br>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,<br>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE<br>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER<br>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,<br>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN<br>THE SOFTWARE.</div></div>
 
       <div id="footer">
-  Generated on Wed May 21 21:33:37 2025 by
+  Generated on Wed May 21 22:09:23 2025 by
   <a href="https://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
   0.9.37 (ruby-3.4.3).
 </div>
diff --git a/doc/file.README.html b/doc/file.README.html
@@ -507,7 +507,7 @@ <h2 id="-one-more-thing">🤑 One more thing</h2>
 </div></div>
 
       <div id="footer">
-  Generated on Wed May 21 21:33:37 2025 by
+  Generated on Wed May 21 22:09:23 2025 by
   <a href="https://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
   0.9.37 (ruby-3.4.3).
 </div>
diff --git a/doc/file.SECURITY.html b/doc/file.SECURITY.html
@@ -104,7 +104,7 @@ <h2 id="snaky-hash-for-enterprise">Snaky Hash for Enterprise</h2>
 </div></div>
 
       <div id="footer">
-  Generated on Wed May 21 21:33:37 2025 by
+  Generated on Wed May 21 22:09:23 2025 by
   <a href="https://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
   0.9.37 (ruby-3.4.3).
 </div>
diff --git a/doc/index.html b/doc/index.html
@@ -507,7 +507,7 @@ <h2 id="-one-more-thing">🤑 One more thing</h2>
 </div></div>
 
       <div id="footer">
-  Generated on Wed May 21 21:33:37 2025 by
+  Generated on Wed May 21 22:09:23 2025 by
   <a href="https://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
   0.9.37 (ruby-3.4.3).
 </div>
diff --git a/doc/top-level-namespace.html b/doc/top-level-namespace.html
@@ -100,7 +100,7 @@ <h2>Defined Under Namespace</h2>
 </div>
 
       <div id="footer">
-  Generated on Wed May 21 21:33:37 2025 by
+  Generated on Wed May 21 22:09:23 2025 by
   <a href="https://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
   0.9.37 (ruby-3.4.3).
 </div>
diff --git a/lib/snaky_hash/serializer.rb b/lib/snaky_hash/serializer.rb
@@ -11,7 +11,7 @@ def extended(base)
         base.extend(extended_module)
         # :nocov:
         # This will be run in CI on Ruby 2.3, but we only collect coverage from current Ruby
-        unless VersionGem::Ruby.gte_minimum_version?("2.4")
+        unless base.instance_methods.include?(:transform_values)
           base.include(BackportedInstanceMethods)
         end
         # :nocov:
@@ -80,7 +80,9 @@ def presence(value)
     end
 
     def dump_hash(hash)
-      hash = hash.transform_values do |value|
+      # The hash will be a raw hash, not a hash of this class.
+      # So first we make it a hash of this class.
+      hash = self[hash].transform_values do |value|
         dump_value(value)
       end
       hash.reject { |_, v| blank?(v) }
diff --git a/spec/shared_examples/a_serialized_hash.rb b/spec/shared_examples/a_serialized_hash.rb
@@ -19,7 +19,7 @@
 
     it "does not remove false" do
       value = subject.dump({hello: "World", falseValue: false})
-      expect(value).to eq '{"hello":"World","falseValue":false}'
+      expect(value).to eq '{"hello":"World","false_value":false}'
     end
 
     it "removes any empty items from top-level arrays" do
