Skip to content

Commit b96ef7a

Browse files
committed
👷 Normalize heads and current workflows
1 parent 88107d8 commit b96ef7a

File tree

8 files changed

+28
-60
lines changed

8 files changed

+28
-60
lines changed

.github/workflows/current.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ concurrency:
2727

2828
jobs:
2929
test:
30-
name: Specs ${{ matrix.ruby }}@${{ matrix.name_extra || '' }}
30+
name: Specs ${{ matrix.ruby }}@${{ matrix.appraisal }}
3131
if: "!contains(github.event.commits[0].message, '[ci skip]') && !contains(github.event.commits[0].message, '[skip ci]')"
3232
runs-on: ubuntu-latest
3333
continue-on-error: ${{ matrix.experimental || endsWith(matrix.ruby, 'head') }}
@@ -38,7 +38,7 @@ jobs:
3838
include:
3939
# Ruby 3.4
4040
- ruby: "ruby"
41-
appraisal: "ruby-current"
41+
appraisal: "current"
4242
exec_cmd: "rake spec"
4343
gemfile: "Appraisal.root"
4444
rubygems: latest
@@ -47,7 +47,7 @@ jobs:
4747

4848
# truffleruby-24.1 (targets Ruby 3.3.5 compatibility)
4949
- ruby: "truffleruby"
50-
appraisal: "ruby-current"
50+
appraisal: "current"
5151
exec_cmd: "rake spec"
5252
gemfile: "Appraisal.root"
5353
rubygems: default
@@ -56,7 +56,7 @@ jobs:
5656

5757
# jruby-9.4 (targets Ruby 3.1 compatibility)
5858
- ruby: "jruby"
59-
appraisal: "ruby-current"
59+
appraisal: "current"
6060
exec_cmd: "rake spec"
6161
gemfile: "Appraisal.root"
6262
rubygems: default
@@ -80,7 +80,7 @@ jobs:
8080
# NOTE: This does not use the main Gemfile at all.
8181
- name: Install Root Appraisal
8282
run: bundle
83-
- name: Appraisal for ${{ matrix.appraisal }}
83+
- name: Appraisal for ${{ matrix.ruby }}@${{ matrix.appraisal }}
8484
run: bundle exec appraisal ${{ matrix.appraisal }} bundle
85-
- name: Tests for ${{ matrix.ruby }}@${{ matrix.name_extra }} via ${{ matrix.exec_cmd }}
85+
- name: Tests for ${{ matrix.ruby }}@${{ matrix.appraisal }} (${{ matrix.name_extra }}?) via ${{ matrix.exec_cmd }}
8686
run: bundle exec appraisal ${{ matrix.appraisal }} bundle exec ${{ matrix.exec_cmd }}

.github/workflows/heads.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ concurrency:
2626

2727
jobs:
2828
test:
29-
name: Specs ${{ matrix.ruby }} ${{ matrix.appraisal }}${{ matrix.name_extra || '' }}
29+
name: Specs ${{ matrix.ruby }}@${{ matrix.appraisal }}${{ matrix.name_extra || '' }}
3030
if: "!contains(github.event.commits[0].message, '[ci skip]') && !contains(github.event.commits[0].message, '[skip ci]')"
3131
runs-on: ubuntu-latest
3232
continue-on-error: ${{ matrix.experimental || endsWith(matrix.ruby, 'head') }}
@@ -39,23 +39,23 @@ jobs:
3939
# NOTE: Heads use default rubygems / bundler; their defaults are custom, unreleased, and from the future!
4040
# ruby-head
4141
- ruby: "ruby-head"
42-
appraisal: "ruby-head"
42+
appraisal: "head"
4343
exec_cmd: "rake spec"
4444
gemfile: "Appraisal.root"
4545
rubygems: default
4646
bundler: default
4747

4848
# truffleruby-head
4949
- ruby: "truffleruby-head"
50-
appraisal: "truffleruby-head"
50+
appraisal: "head"
5151
exec_cmd: "rake spec"
5252
gemfile: "Appraisal.root"
5353
rubygems: default
5454
bundler: default
5555

5656
# jruby-head
5757
- ruby: "jruby-head"
58-
appraisal: "jruby-head"
58+
appraisal: "head"
5959
exec_cmd: "rake spec"
6060
gemfile: "Appraisal.root"
6161
rubygems: default
@@ -78,7 +78,7 @@ jobs:
7878
# NOTE: This does not use the main Gemfile at all.
7979
- name: Install Root Appraisal
8080
run: bundle
81-
- name: Appraisal for ${{ matrix.appraisal }}
81+
- name: Appraisal for ${{ matrix.ruby }}@${{ matrix.appraisal }}
8282
run: bundle exec appraisal ${{ matrix.appraisal }} bundle
83-
- name: Tests for ${{ matrix.ruby }} via ${{ matrix.exec_cmd }}
83+
- name: Tests for ${{ matrix.ruby }}@${{ matrix.appraisal }} via ${{ matrix.exec_cmd }}
8484
run: bundle exec appraisal ${{ matrix.appraisal }} bundle exec ${{ matrix.exec_cmd }}

Appraisals

Lines changed: 16 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,21 @@
11
# frozen_string_literal: true
22

3+
# Used for head (nightly) releases of ruby, truffleruby, and jruby.
4+
# Split into discrete appraisals if one of them needs a dependency locked discretely.
5+
appraise "head" do
6+
gem "mutex_m", ">= 0.2"
7+
gem "stringio", ">= 3.0"
8+
remove_gem "appraisal" # only present because it must be in the gemfile because we target a git branch
9+
end
10+
11+
# Used for current releases of ruby, truffleruby, and jruby.
12+
# Split into discrete appraisals if one of them needs a dependency locked discretely.
13+
appraise "current" do
14+
gem "mutex_m", ">= 0.2"
15+
gem "stringio", ">= 3.0"
16+
remove_gem "appraisal" # only present because it must be in the gemfile because we target a git branch
17+
end
18+
319
appraise "ruby-2-2" do
420
remove_gem "appraisal" # only present because it must be in the gemfile because we target a git branch
521
end
@@ -52,12 +68,6 @@ appraise "ruby-3-3" do
5268
remove_gem "appraisal" # only present because it must be in the gemfile because we target a git branch
5369
end
5470

55-
appraise "ruby-current" do
56-
gem "mutex_m", ">= 0.2"
57-
gem "stringio", ">= 3.0"
58-
remove_gem "appraisal" # only present because it must be in the gemfile because we target a git branch
59-
end
60-
6171
# Only run security audit on latest Ruby version
6272
appraise "audit" do
6373
gem "mutex_m", "~> 0.2"
@@ -81,21 +91,3 @@ appraise "style" do
8191
eval_gemfile "modular/style.gemfile"
8292
remove_gem "appraisal" # only present because it must be in the gemfile because we target a git branch
8393
end
84-
85-
appraise "ruby-head" do
86-
gem "mutex_m", ">= 0.2"
87-
gem "stringio", ">= 3.0"
88-
remove_gem "appraisal" # only present because it must be in the gemfile because we target a git branch
89-
end
90-
91-
appraise "truffleruby-head" do
92-
gem "mutex_m", ">= 0.2"
93-
gem "stringio", ">= 3.0"
94-
remove_gem "appraisal" # only present because it must be in the gemfile because we target a git branch
95-
end
96-
97-
appraise "jruby-head" do
98-
gem "mutex_m", ">= 0.2"
99-
gem "stringio", ">= 3.0"
100-
remove_gem "appraisal" # only present because it must be in the gemfile because we target a git branch
101-
end
File renamed without changes.
File renamed without changes.

gemfiles/ruby_3_4.gemfile

Lines changed: 0 additions & 8 deletions
This file was deleted.

gemfiles/ruby_head.gemfile

Lines changed: 0 additions & 8 deletions
This file was deleted.

gemfiles/truffleruby_head.gemfile

Lines changed: 0 additions & 8 deletions
This file was deleted.

0 commit comments

Comments
 (0)