🔧 minitest-retry

Author: pboling

test/functional/masq/sessions_controller_test.rb

@@ -15,7 +15,7 @@ def test_should_redirect_to_users_identity_page_after_successful_login
       assert_redirected_to(identity_url(account, host: Masq::Engine.config.masq["host"]))
     end
 
-    def test_should_redirect_to_users_on_login_if_allready_logged_in
+    def test_should_redirect_to_users_on_login_if_already_logged_in
       login_as(:standard)
       account = accounts(:standard)
       get(:new)
@@ -123,6 +123,9 @@ def test_should_authenticate_with_password_and_yubico_otp
       yubico_otp = @account.yubico_identity + "x" * 32
       Account.expects(:verify_yubico_otp).with(yubico_otp).returns(true)
       post(:create, params: {login: @account.login, password: "test" + yubico_otp})
+      # TODO: Why does the account save seems to be very slow sometimes?
+      #       Or is it failing to save the account randomly?
+      sleep(1)
       @account.reload
       assert_not_nil(@account.last_authenticated_at)
       assert(@account.last_authenticated_by_yubikey)

test/test_helper.rb

@@ -9,12 +9,10 @@
 
 Minitest::Retry.use!(
   retry_count:  3,         # The number of times to retry. The default is 3.
-  verbose: true,           # Whether or not to display the message at the time of retry. The default is true.
+  verbose: true,           # Whether to display the message at the time of retry. The default is true.
   io: $stdout,             # Display destination of retry when the message. The default is stdout.
   exceptions_to_retry: [], # List of exceptions that will trigger a retry (when empty, all exceptions will).
-  methods_to_retry:    [
-    :test_should_authenticate_with_password_and_yubico_otp,
-  ], # List of methods that will trigger a retry (when empty, all methods will).
+  methods_to_retry:    [], # List of methods that will trigger a retry (when empty, all methods will).
   classes_to_retry:    [], # List of classes that will trigger a retry (when empty, all classes will).
   methods_to_skip:     [], # List of methods that will skip a retry (when empty, all methods will retry).
   exceptions_to_skip:  [],  # List of exceptions that will skip a retry (when empty, all exceptions will retry).