Skip to content

Commit 95dc9a2

Browse files
authored
Fix sidebar typo (#294)
* Fix sidebar typo * Add a test case for the non collapsible variant
1 parent 0b75a1e commit 95dc9a2

File tree

4 files changed

+64
-4
lines changed

4 files changed

+64
-4
lines changed

lib/ruby_ui/sidebar/collapsiable_sidebar.rb renamed to lib/ruby_ui/sidebar/collapsible_sidebar.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22

33
module RubyUI
4-
class CollapsiableSidebar < Base
4+
class CollapsibleSidebar < Base
55
def initialize(side: :left, variant: :sidebar, collapsible: :offcanvas, open: true, **attrs)
66
@side = side
77
@variant = variant

lib/ruby_ui/sidebar/non_collapsible_sidebar.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22

33
module RubyUI
4-
class NonCollpapsibleSidebar < Base
4+
class NonCollapsibleSidebar < Base
55
def view_template(&)
66
div(**attrs, &)
77
end

lib/ruby_ui/sidebar/sidebar.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ def initialize(side: :left, variant: :sidebar, collapsible: :offcanvas, open: tr
2020

2121
def view_template(&)
2222
if @collapsible == :none
23-
NonCollapsiableSidebar(**attrs, &)
23+
NonCollapsibleSidebar(**attrs, &)
2424
else
25-
CollapsiableSidebar(side: @side, variant: @variant, collapsible: @collapsible, open: @open, **attrs, &)
25+
CollapsibleSidebar(side: @side, variant: @variant, collapsible: @collapsible, open: @open, **attrs, &)
2626
end
2727
end
2828
end

test/ruby_ui/sidebar_test.rb

Lines changed: 60 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,66 @@ def test_render_with_all_items
6363
assert_match(/Footer/, output)
6464
end
6565

66+
def test_render_non_collapsible_sidebar
67+
output = phlex do
68+
RubyUI.SidebarWrapper do
69+
RubyUI.Sidebar(collapsible: :none) do
70+
RubyUI.SidebarHeader do
71+
RubyUI.SidebarGroup do
72+
RubyUI.SidebarGroupContent do
73+
RubyUI.SidebarInput(id: "search", placeholder: "Search the docs")
74+
end
75+
end
76+
end
77+
RubyUI.SidebarContent do
78+
RubyUI.SidebarGroup do
79+
RubyUI.SidebarGroupLabel { "Application" }
80+
RubyUI.SidebarGroupAction { "Group Action" }
81+
RubyUI.SidebarGroupContent do
82+
RubyUI.SidebarMenu do
83+
RubyUI.SidebarMenuItem do
84+
RubyUI.SidebarMenuSub do
85+
RubyUI.SidebarMenuSubItem do
86+
RubyUI.SidebarMenuSubButton(as: :a, href: "#") { "Sub Item 1" }
87+
end
88+
end
89+
end
90+
RubyUI.SidebarMenuItem do
91+
RubyUI.SidebarMenuButton(as: :a, href: "#") { "Settings" }
92+
RubyUI.SidebarMenuAction { "Settings" }
93+
end
94+
RubyUI.SidebarMenuItem do
95+
RubyUI.SidebarMenuButton { "Dashboard" }
96+
RubyUI.SidebarMenuAction { "Dashboard" }
97+
RubyUI.SidebarMenuBadge { "Dashboard Badge" }
98+
end
99+
RubyUI.SidebarMenuItem do
100+
RubyUI.SidebarMenuSkeleton()
101+
end
102+
end
103+
end
104+
end
105+
RubyUI.SidebarSeparator()
106+
end
107+
RubyUI.SidebarFooter { "Footer" }
108+
RubyUI.SidebarRail()
109+
end
110+
RubyUI.SidebarInset do
111+
RubyUI.SidebarTrigger()
112+
end
113+
end
114+
end
115+
116+
assert_match(/Search the docs/, output)
117+
assert_match(/Application/, output)
118+
assert_match(/Group Action/, output)
119+
assert_match(/Sub Item 1/, output)
120+
assert_match(/Settings/, output)
121+
assert_match(/Dashboard/, output)
122+
assert_match(/Dashboard Badge/, output)
123+
assert_match(/Footer/, output)
124+
end
125+
66126
def test_with_side_right
67127
output = phlex do
68128
RubyUI.Sidebar(side: :right)

0 commit comments

Comments
 (0)