Skip to content

Commit 2b9f095

Browse files
authored
UPDATE RUBY_UI + QUICK FIX VIEW CHECKBOX_GROUP (#127)
* UPDATE RUBY_UI * CheckboxGroup -> Checkbox Group * 1st OK * 1st OK
1 parent 4dd7f90 commit 2b9f095

File tree

6 files changed

+42
-35
lines changed

6 files changed

+42
-35
lines changed

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,6 @@ end
7676
gem "phlex-rails"
7777

7878
gem "ruby_ui", github: "ruby-ui/ruby_ui", branch: "main"
79-
# gem "ruby_ui", path: "../rbui"
79+
# gem "ruby_ui", path: "../ruby_ui"
8080

8181
gem "pry"

Gemfile.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
GIT
22
remote: https://github.com/ruby-ui/ruby_ui.git
3-
revision: 33dc56c7565e64080f976594b7a67eb0b7e2412f
3+
revision: 5519a5f06e104c55141ff698e391befb7b61469f
44
branch: main
55
specs:
66
ruby_ui (1.0.0.pre.alpha.4)
7-
phlex (~> 1.10, < 3)
7+
phlex (>= 1.10, < 3)
88
rouge (~> 4.2.0)
99
tailwind_merge (~> 0.12)
1010

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ Here is the list of components that are being built. For reference, see here htt
1414
✅ Calendar
1515
✅ Card
1616
✅ Checkbox
17-
CheckboxGroup
17+
Checkbox Group
1818
✅ Codeblock
1919
✅ Collapsible
2020
⚪️ Combobox

app/views/components/shared/menu.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ def components
7272
{name: "Calendar", path: helpers.docs_calendar_path},
7373
# { name: "Chart", path: helpers.docs_chart_path, badge: "New" },
7474
{name: "Checkbox", path: helpers.docs_checkbox_path},
75-
{name: "CheckboxGroup", path: helpers.docs_checkbox_group_path},
75+
{name: "Checkbox Group", path: helpers.docs_checkbox_group_path},
7676
{name: "Clipboard", path: helpers.docs_clipboard_path},
7777
{name: "Codeblock", path: helpers.docs_codeblock_path},
7878
{name: "Collapsible", path: helpers.docs_collapsible_path},

app/views/docs/checkbox_group_view.rb

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22

33
class Docs::CheckboxGroupView < ApplicationView
44
def view_template
5-
component = "CheckboxGroup"
5+
component = "Checkbox Group"
66

77
div(class: "max-w-2xl mx-auto w-full py-10 space-y-10") do
8-
render Docs::Header.new(title: "CheckboxGroup", description: "A control that allows the user to toggle between checked and not checked.")
8+
render Docs::Header.new(title: "Checkbox Group", description: "A control that allows the user to toggle between checked and not checked.")
99

1010
Heading(level: 2) { "Usage" }
1111

@@ -14,13 +14,13 @@ def view_template
1414
CheckboxGroup(data_required: true) do
1515
div(class: "flex flex-col gap-2") do
1616
div(class: "flex flex-row items-center gap-2") do
17-
Checkbox(value: "FOO", id: "FOO")
18-
FormFieldLabel(for: "FOO") { "FOO" }
17+
Checkbox(value: "FOO", id: "EXAMPLE_FOO")
18+
FormFieldLabel(for: "EXAMPLE_FOO") { "FOO" }
1919
end
2020
2121
div(class: "flex flex-row items-center gap-2") do
22-
Checkbox(value: "BAR", id: "BAR")
23-
FormFieldLabel(for: "BAR") { "BAR" }
22+
Checkbox(value: "BAR", id: "EXAMPLE_BAR")
23+
FormFieldLabel(for: "EXAMPLE_BAR") { "BAR" }
2424
end
2525
end
2626
end
@@ -39,26 +39,26 @@ def view_template
3939
div(class: "flex flex-col gap-2") do
4040
div(class: "flex flex-row items-center gap-2") do
4141
Checkbox(
42-
id: "FOO",
42+
id: "FORM_FOO",
4343
value: "FOO",
4444
checked: false,
4545
name: "CHECKBOX_GROUP[]",
4646
data: {value_missing: "CUSTOM_MESSAGE"}
4747
)
4848
49-
FormFieldLabel(for: "FOO") { "FOO" }
49+
FormFieldLabel(for: "FORM_FOO") { "FOO" }
5050
end
5151
5252
div(class: "flex flex-row items-center gap-2") do
5353
Checkbox(
54-
id: "BAR",
54+
id: "FORM_BAR",
5555
value: "BAR",
5656
checked: true,
5757
name: "CHECKBOX_GROUP[]",
5858
data: {value_missing: "CUSTOM_MESSAGE"}
5959
)
6060
61-
FormFieldLabel(for: "BAR") { "BAR" }
61+
FormFieldLabel(for: "FORM_BAR") { "BAR" }
6262
end
6363
end
6464
end

yarn.lock

Lines changed: 27 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@
88
integrity sha512-UrcABB+4bUrFABwbluTIBErXwvbsU/V7TZWfmbgJfbkwiBuziS9gxdODUyuiecfdGQ85jglMW6juS3+z5TsKLw==
99

1010
"@babel/runtime@^7.21.0":
11-
version "7.25.0"
12-
resolved "https://registry.yarnpkg.com/@babel/runtime/-/runtime-7.25.0.tgz#3af9a91c1b739c569d5d80cc917280919c544ecb"
13-
integrity sha512-7dRy4DwXwtzBrPbZflqxnvfxLF8kdZXPkhymtDeFoFqE6ldzjQFgYTtYIFARcLEYDrqfBfYcZt1WqFxRoyC9Rw==
11+
version "7.26.0"
12+
resolved "https://registry.yarnpkg.com/@babel/runtime/-/runtime-7.26.0.tgz#8600c2f595f277c60815256418b85356a65173c1"
13+
integrity sha512-FDSOghenHTiToteC/QRlv2q3DhPZ/oOXTBoirfWNx1Cx3TMVcGWQtMMmQcSvb/JjpNeGzx8Pq/b4fKEJuWm1sw==
1414
dependencies:
1515
regenerator-runtime "^0.14.0"
1616

@@ -135,24 +135,24 @@
135135
integrity sha512-Arm+WgUFLUATuoxCJcahGuk6Yj9Pzxd6l11Zb/2aAuv5kWWvvfhLFo2fni4uSK5vzlUdCGZ/BdV5tH8klj8p8g==
136136

137137
"@floating-ui/core@^1.6.0":
138-
version "1.6.7"
139-
resolved "https://registry.yarnpkg.com/@floating-ui/core/-/core-1.6.7.tgz#7602367795a390ff0662efd1c7ae8ca74e75fb12"
140-
integrity sha512-yDzVT/Lm101nQ5TCVeK65LtdN7Tj4Qpr9RTXJ2vPFLqtLxwOrpoxAHAJI8J3yYWUc40J0BDBheaitK5SJmno2g==
138+
version "1.6.8"
139+
resolved "https://registry.yarnpkg.com/@floating-ui/core/-/core-1.6.8.tgz#aa43561be075815879305965020f492cdb43da12"
140+
integrity sha512-7XJ9cPU+yI2QeLS+FCSlqNFZJq8arvswefkZrYI1yQBbftw6FyrZOxYSh+9S7z7TpeWlRt9zJ5IhM1WIL334jA==
141141
dependencies:
142-
"@floating-ui/utils" "^0.2.7"
142+
"@floating-ui/utils" "^0.2.8"
143143

144144
"@floating-ui/dom@^1.6.8":
145-
version "1.6.10"
146-
resolved "https://registry.yarnpkg.com/@floating-ui/dom/-/dom-1.6.10.tgz#b74c32f34a50336c86dcf1f1c845cf3a39e26d6f"
147-
integrity sha512-fskgCFv8J8OamCmyun8MfjB1Olfn+uZKjOKZ0vhYF3gRmEUXcGOjxWL8bBr7i4kIuPZ2KD2S3EUIOxnjC8kl2A==
145+
version "1.6.12"
146+
resolved "https://registry.yarnpkg.com/@floating-ui/dom/-/dom-1.6.12.tgz#6333dcb5a8ead3b2bf82f33d6bc410e95f54e556"
147+
integrity sha512-NP83c0HjokcGVEMeoStg317VD9W7eDlGK7457dMBANbKA6GJZdc7rjujdgqzTaz93jkGgc5P/jeWbaCHnMNc+w==
148148
dependencies:
149149
"@floating-ui/core" "^1.6.0"
150-
"@floating-ui/utils" "^0.2.7"
150+
"@floating-ui/utils" "^0.2.8"
151151

152-
"@floating-ui/utils@^0.2.7":
153-
version "0.2.7"
154-
resolved "https://registry.yarnpkg.com/@floating-ui/utils/-/utils-0.2.7.tgz#d0ece53ce99ab5a8e37ebdfe5e32452a2bfc073e"
155-
integrity sha512-X8R8Oj771YRl/w+c1HqAC1szL8zWQRwFvgDwT129k9ACdBoud/+/rX9V0qiMl6LWUdP9voC2nDVZYPMQQsb6eA==
152+
"@floating-ui/utils@^0.2.8":
153+
version "0.2.8"
154+
resolved "https://registry.yarnpkg.com/@floating-ui/utils/-/utils-0.2.8.tgz#21a907684723bbbaa5f0974cf7730bd797eb8e62"
155+
integrity sha512-kym7SodPp8/wloecOpcmSnWJsK7M0E5Wg8UcFA+uO4B9s5d0ywXOEro/8HM9x0rW+TljRzul/14UYz3TleT3ig==
156156

157157
"@hotwired/[email protected]", "@hotwired/stimulus@^3.2.2":
158158
version "3.2.2"
@@ -368,13 +368,20 @@ caniuse-lite@^1.0.30001599, caniuse-lite@^1.0.30001640:
368368
resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001643.tgz#9c004caef315de9452ab970c3da71085f8241dbd"
369369
integrity sha512-ERgWGNleEilSrHM6iUz/zJNSQTP8Mr21wDWpdgvRwcTXGAq6jMtOUPP4dqFPTdKqZ2wKTdtB+uucZ3MRpAUSmg==
370370

371-
[email protected], chart.js@^4.4.1:
371+
372372
version "4.4.3"
373373
resolved "https://registry.yarnpkg.com/chart.js/-/chart.js-4.4.3.tgz#3b2e11e7010fefa99b07d0349236f5098e5226ad"
374374
integrity sha512-qK1gkGSRYcJzqrrzdR6a+I0vQ4/R+SoODXyAjscQ/4mzuNzySaMCd+hyVxitSY1+L2fjPD1Gbn+ibNqRmwQeLw==
375375
dependencies:
376376
"@kurkle/color" "^0.3.0"
377377

378+
chart.js@^4.4.1:
379+
version "4.4.6"
380+
resolved "https://registry.yarnpkg.com/chart.js/-/chart.js-4.4.6.tgz#da39b84ca752298270d4c0519675c7659936abec"
381+
integrity sha512-8Y406zevUPbbIBA/HRk33khEmQPk5+cxeflWE/2rx1NJsjVWMPw/9mSP9rxHP5eqi6LNoPBVMfZHxbwLSgldYA==
382+
dependencies:
383+
"@kurkle/color" "^0.3.0"
384+
378385
chokidar@^3.5.3:
379386
version "3.5.3"
380387
resolved "https://registry.npmjs.org/chokidar/-/chokidar-3.5.3.tgz"
@@ -854,7 +861,7 @@ reusify@^1.0.4:
854861

855862
ruby_ui_js@ruby-ui/ruby_ui:
856863
version "1.0.0-alpha.4"
857-
resolved "https://codeload.github.com/ruby-ui/ruby_ui/tar.gz/0ae3ed06e7ce56f17c67e2aa530f7fc2c806dc74"
864+
resolved "https://codeload.github.com/ruby-ui/ruby_ui/tar.gz/5519a5f06e104c55141ff698e391befb7b61469f"
858865
dependencies:
859866
"@floating-ui/dom" "^1.6.8"
860867
"@hotwired/stimulus" "^3.2.2"
@@ -967,9 +974,9 @@ ts-interface-checker@^0.1.9:
967974
integrity sha512-Y/arvbn+rrz3JCKl9C4kVNfTfSm2/mEp5FSz5EsZSANGPSlQrpRI5M4PKF+mJnE52jOO90PnPSc3Ur3bTQw0gA==
968975

969976
tslib@^2.3.1:
970-
version "2.6.3"
971-
resolved "https://registry.yarnpkg.com/tslib/-/tslib-2.6.3.tgz#0438f810ad7a9edcde7a241c3d80db693c8cbfe0"
972-
integrity sha512-xNvxJEOUiWPGhUuUdQgAJPKOOJfGnIyKySOc09XkKsgdUV/3E2zvwZYdejjmRgPCgcym1juLH3226yA7sEFJKQ==
977+
version "2.8.1"
978+
resolved "https://registry.yarnpkg.com/tslib/-/tslib-2.8.1.tgz#612efe4ed235d567e8aba5f2a5fab70280ade83f"
979+
integrity sha512-oJFu94HQb+KVduSUQL7wnpmqnfmLsOA/nAh6b6EH0wCEoK0/mPeXU6c3wKDV83MkOuHPRHtSXKKU99IBazS/2w==
973980

974981
update-browserslist-db@^1.1.0:
975982
version "1.1.0"

0 commit comments

Comments
 (0)