fix: fix and test reload_from_s3

Author: kzys

app/models/message.rb

@@ -37,19 +37,21 @@ def self.from_string(str)
         published_at = DateTime.strptime(headers['Date'], '%Y-%m-%dT%H:%M:%S%:z')
 
         self.new(
-            body: body,
+            body: Kconv.toutf8(body),
             subject: headers['Subject'],
             from: headers['From'],
             published_at: published_at,
         )
     end
 
-    def reload_from_s3
-        m = self.from_s3(List.find_by_id(self.list_id).name, self.list_seq)
+    def reload_from_s3(s3_client = Aws::S3::Client.new(region: BLADE_BUCKET_REGION))
+        m = Message.from_s3(List.find_by_id(self.list_id).name, self.list_seq, s3_client)
 
         self.body = m.body
         self.subject = m.subject
         self.from = from
         self.published_at = m.published_at
+
+        m
     end
 end

test/models/message_test.rb

@@ -26,4 +26,21 @@ class MessageTest < ActiveSupport::TestCase
 END_OF_BODY
     Message.from_s3('ruby-list', 1234, s3_client)
   end
+
+  test 'reload_from_s3' do
+    s3_client = Aws::S3::Client.new(stub_responses: true)
+    s3_client.stub_responses(:get_object, body: <<END_OF_BODY)
+Subject: [ruby-list:1] Hello
+From: alice@...
+Date: 2005-12-15T19:32:40+09:00
+
+Hello, world!
+END_OF_BODY
+
+    m = Message.new
+    m.list_id = 1
+    m.list_seq = 1
+    m.reload_from_s3(s3_client)
+    assert_equal '[ruby-list:1] Hello', m.subject
+  end
 end