Merge pull request #53 from amatsuda/content_for_in_partial

amatsuda · web-flow · commit cd5c23af8446 · 2025-10-15T22:20:05.000+09:00
Let's not set :title inside a partial
diff --git a/app/views/messages/_message.html.erb b/app/views/messages/_message.html.erb
@@ -1,5 +1,3 @@
-<% content_for :title, message.subject %>
-
 <div class="message" id="<%= dom_id message %>">
   <ul class="headers">
     <li>From: <%= message.from %></li>
diff --git a/app/views/messages/show.html.erb b/app/views/messages/show.html.erb
@@ -1,3 +1,5 @@
+<% content_for :title, @message.subject %>
+
 <p style="color: green"><%= notice %></p>
 
 <%= render @message %>

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-<% content_for :title, message.subject %>`
`2`		`-`
`3`	`1`	`<div class="message" id="<%= dom_id message %>">`
`4`	`2`	`<ul class="headers">`
`5`	`3`	`<li>From: <%= message.from %></li>`