Add RBS type definitions for Redis hash commands#966
Merged
github-actions[bot] merged 1 commit intoruby:mainfrom Dec 31, 2025
Merged
Add RBS type definitions for Redis hash commands#966github-actions[bot] merged 1 commit intoruby:mainfrom
github-actions[bot] merged 1 commit intoruby:mainfrom
Conversation
|
@bolshakov Thanks for your contribution! Please follow the instructions below for each change. Available commandsYou can use the following commands by commenting on this PR.
|
Introduces `type arg = String | Symbol | Integer | Float` to represent the only types the Redis client accepts for keys and values. Methods like `hmget` and `hmset` use explicit tuple overloads for common arities (1-7 fields) to provide precise return types. For example, `hmget` with 3 fields returns `[String?, String?, String?]` rather than `Array[String?]`. This enables the type checker to catch arity mismatches and gives callers exact knowledge of result structure. Falls back to `Array[String?]` for 7+ fields where tuple precision becomes impractical.
bolshakov
force-pushed
the
feature/redis-hash
branch
from
bba6e9b to
d109a5b
Compare
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces
type arg = String | Symbol | Integer | Floatto represent the only types the Redis client accepts for keys and values.Methods like
hmgetandhmsetuse explicit tuple overloads for common arities (1-7 fields) to provide precise return types. For example,hmgetwith 3 fields returns[String?, String?, String?]rather thanArray[String?]. This enables the type checker to catch arity mismatches and gives callers exact knowledge of the result structure.Falls back to
Array[String?]for 7+ fields where tuple precision becomes impractical.I skipped two methods -
hscanandhscan_eachas I never used them and need more type understanding how they work 😅