Merge pull request #217 from jasonrclark/dont_mutate_dump_default_options

Don't mutate JSON.dump_default_options from dump

Author: flori

lib/json/common.rb

@@ -390,7 +390,7 @@ def dump(obj, anIO = nil, limit = nil)
       end
     end
     opts = JSON.dump_default_options
-    limit and opts.update(:max_nesting => limit)
+    opts = opts.merge(:max_nesting => limit) if limit
     result = generate(obj, opts)
     if anIO
       anIO.write result

tests/test_json.rb

@@ -515,6 +515,12 @@ def test_dump
     assert_equal too_deep, output.string
   end
 
+  def test_dump_should_modify_defaults
+    max_nesting = JSON.dump_default_options[:max_nesting]
+    JSON.dump([], StringIO.new, 10)
+    assert_equal max_nesting, JSON.dump_default_options[:max_nesting]
+  end
+
   def test_big_integers
     json1 = JSON([orig = (1 << 31) - 1])
     assert_equal orig, JSON[json1][0]