Skip to content

Commit 321a859

Browse files
committed
♻️ Make ResponseCode after resp-text-code case stmt
a simple refactoring to extract the common code
1 parent c0e9c37 commit 321a859

File tree

1 file changed

+9
-12
lines changed

1 file changed

+9
-12
lines changed

lib/net/imap/response_parser.rb

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1498,28 +1498,25 @@ def resp_text_code
14981498
name = resp_text_code__name
14991499
case name
15001500
when "ALERT", "PARSE", "READ-ONLY", "READ-WRITE", "TRYCREATE", "NOMODSEQ"
1501-
ResponseCode.new(name, nil)
1501+
data = nil
15021502
when "BADCHARSET"
1503-
ResponseCode.new(name, charset_list)
1503+
data = charset_list
15041504
when "CAPABILITY"
1505-
ResponseCode.new(name, capability__list)
1505+
data = capability__list
15061506
when "PERMANENTFLAGS"
15071507
SP!
1508-
ResponseCode.new(name, flag_list)
1508+
data = flag_list
15091509
when "UIDVALIDITY", "UIDNEXT", "UNSEEN"
15101510
SP!
1511-
ResponseCode.new(name, number)
1511+
data = number
15121512
when "APPENDUID"
1513-
ResponseCode.new(name, resp_code_apnd__data)
1513+
data = resp_code_apnd__data
15141514
when "COPYUID"
1515-
ResponseCode.new(name, resp_code_copy__data)
1515+
data = resp_code_copy__data
15161516
else
1517-
if SP?
1518-
ResponseCode.new(name, text_chars_except_rbra)
1519-
else
1520-
ResponseCode.new(name, nil)
1521-
end
1517+
data = SP? && text_chars_except_rbra
15221518
end
1519+
ResponseCode.new(name, data)
15231520
end
15241521

15251522
alias resp_text_code__name case_insensitive__atom

0 commit comments

Comments
 (0)