♻️ Move resp-text response parser tests to yaml

Author: nevans

test/net/imap/fixtures/response_parser/resp_text_responses.yml

@@ -0,0 +1,40 @@
+---
+:tests:
+  test_resp_text_with_code:
+    :response: "* OK [CLOSED] Previous mailbox closed.\r\n"
+    :expected: !ruby/struct:Net::IMAP::UntaggedResponse
+      name: OK
+      data: !ruby/struct:Net::IMAP::ResponseText
+        code: !ruby/struct:Net::IMAP::ResponseCode
+          name: CLOSED
+          data:
+        text: Previous mailbox closed.
+      raw_data: "* OK [CLOSED] Previous mailbox closed.\r\n"
+
+  test_resp_text_with_T_LBRA:
+    :response: "RUBY0004 OK [READ-WRITE] [Gmail]/Sent Mail selected. (Success)\r\n"
+    :expected: !ruby/struct:Net::IMAP::TaggedResponse
+      tag: RUBY0004
+      name: OK
+      data: !ruby/struct:Net::IMAP::ResponseText
+        code: !ruby/struct:Net::IMAP::ResponseCode
+          name: READ-WRITE
+          data:
+        text: "[Gmail]/Sent Mail selected. (Success)"
+      raw_data: "RUBY0004 OK [READ-WRITE] [Gmail]/Sent Mail selected. (Success)\r\n"
+
+  test_resp_text_with_BADCHARSET_astrings:
+    :response: "t BAD [BADCHARSET (US-ASCII \"[astring with brackets]\")] unsupported
+      charset foo.\r\n"
+    :expected: !ruby/struct:Net::IMAP::TaggedResponse
+      tag: t
+      name: BAD
+      data: !ruby/struct:Net::IMAP::ResponseText
+        code: !ruby/struct:Net::IMAP::ResponseCode
+          name: BADCHARSET
+          data:
+          - US-ASCII
+          - "[astring with brackets]"
+        text: unsupported charset foo.
+      raw_data: "t BAD [BADCHARSET (US-ASCII \"[astring with brackets]\")] unsupported
+        charset foo.\r\n"

test/net/imap/test_imap_response_parser.rb

@@ -27,6 +27,9 @@ def teardown
   ############################################################################
   # Core IMAP, by RFC9051 section (w/obsolete in relative RFC3501 section):
 
+  # §7.1: Generic Status Responses (OK, NO, BAD, PREAUTH, BYE, codes, text)
+  generate_tests_from fixture_file: "resp_text_responses.yml"
+
   # §7.2.2: CAPABILITY response
   generate_tests_from fixture_file: "capability_responses.yml"
 
@@ -78,14 +81,6 @@ def test_flag_xlist_inbox
     assert_equal [:Inbox], response.data.attr
   end
 
-  def test_resp_text_code
-    parser = Net::IMAP::ResponseParser.new
-    response = parser.parse(<<EOF.gsub(/\n/, "\r\n"))
-* OK [CLOSED] Previous mailbox closed.
-EOF
-    assert_equal "CLOSED", response.data.code.name
-  end
-
   def test_msg_att_extra_space
     parser = Net::IMAP::ResponseParser.new
     response = parser.parse(<<EOF.gsub(/\n/, "\r\n"))
@@ -158,22 +153,6 @@ def test_msg_att_modseq_data
     assert_equal(12345, response.data.attr["MODSEQ"])
   end
 
-  def test_msg_rfc3501_response_text_with_T_LBRA
-    parser = Net::IMAP::ResponseParser.new
-    response = parser.parse("RUBY0004 OK [READ-WRITE] [Gmail]/Sent Mail selected. (Success)\r\n")
-    assert_equal("RUBY0004", response.tag)
-    assert_equal("READ-WRITE", response.data.code.name)
-    assert_equal("[Gmail]/Sent Mail selected. (Success)", response.data.text)
-  end
-
-  def test_msg_rfc3501_response_text_with_BADCHARSET_astrings
-    parser = Net::IMAP::ResponseParser.new
-    response = parser.parse("t BAD [BADCHARSET (US-ASCII \"[astring with brackets]\")] unsupported charset foo.\r\n")
-    assert_equal("t", response.tag)
-    assert_equal("unsupported charset foo.", response.data.text)
-    assert_equal("BADCHARSET", response.data.code.name)
-  end
-
   def test_continuation_request_without_response_text
     parser = Net::IMAP::ResponseParser.new
     response = parser.parse("+\r\n")