backwards compatible to very old ruby

Author: mohamedhafez

lib/net/smtp.rb

@@ -660,8 +660,8 @@ def finish
 
     private
 
-    def tcp_socket(address, port, **kwargs)
-      TCPSocket.open(address, port, **kwargs)
+    def tcp_socket(*args, **kwargs)
+      TCPSocket.open(*args, **kwargs)
     end
 
     def do_start(helo_domain, user, secret, authtype)
@@ -674,11 +674,11 @@ def do_start(helo_domain, user, secret, authtype)
           case @tcp_socket_supports_open_timeout
           when nil, true
             begin
-              sock = tcp_socket(@address, @port, open_timeout: @open_timeout)
+              sock = tcp_socket(@address, @port, nil, nil, open_timeout: @open_timeout)
               @tcp_socket_supports_open_timeout = true
               sock
             rescue ArgumentError => e
-              raise unless e.message.include?('unknown keyword: :open_timeout') || e.message.include?('wrong number of arguments')
+              raise unless e.message.include?('unknown keyword: :open_timeout') || e.message.include?('wrong number of arguments (given 5, expected 2..4)')
               @tcp_socket_supports_open_timeout = false
 
               Timeout.timeout(@open_timeout, Net::OpenTimeout) do

test/net/smtp/test_sslcontext.rb

@@ -21,7 +21,7 @@ def initialize(socket, **kw)
         super("localhost", **kw)
       end
 
-      def tcp_socket(*, **)
+      def tcp_socket(*args, **kwargs)
         @fake_socket
       end
 

test/net/smtp/test_starttls.rb

@@ -14,7 +14,7 @@ def initialize(socket)
         super("smtp.example.com")
       end
 
-      def tcp_socket(*, **)
+      def tcp_socket(*args, **kwargs)
         @fake_socket
       end