Skip to content

Commit 140900a

Browse files
committed
Reenable windows CI that were disabled because of fiddle
Followup to cd91afe Since this is still an issue, I added it to the gemfile instead of skipping the job It can be removed once https://bugs.ruby-lang.org/issues/21645 is resolved
1 parent cd91afe commit 140900a

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

.github/workflows/main.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ jobs:
6565
- ubuntu-latest
6666
- ubuntu-24.04-arm
6767
- macos-latest
68-
# - windows-latest <-- failing with fiddle error, temporarily disabled
68+
- windows-latest
6969
runs-on: ${{ matrix.os }}
7070
steps:
7171
- uses: actions/checkout@v5
@@ -145,7 +145,7 @@ jobs:
145145
- ubuntu-latest
146146
- ubuntu-24.04-arm
147147
- macos-latest
148-
# - windows-latest <-- failing with fiddle error, temporarily disabled
148+
- windows-latest
149149
runs-on: ${{ matrix.os }}
150150
steps:
151151
- uses: actions/checkout@v5

Gemfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ gem "test-unit"
1111

1212
platforms :mri, :mswin, :mingw, :x64_mingw do
1313
gem "ffi"
14+
# FIXME: https://bugs.ruby-lang.org/issues/21645
15+
gem "fiddle"
1416
gem "parser"
1517
gem "ruby_memcheck"
1618
gem "ruby_parser"

Gemfile.lock

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ GEM
1111
date (3.4.1)
1212
erb (5.1.1)
1313
ffi (1.17.2)
14+
fiddle (1.1.8)
1415
mini_portile2 (2.8.9)
1516
nokogiri (1.18.10)
1617
mini_portile2 (~> 2.8.2)
@@ -48,6 +49,7 @@ PLATFORMS
4849
DEPENDENCIES
4950
benchmark-ips
5051
ffi
52+
fiddle
5153
onigmo
5254
parser
5355
prism!

0 commit comments

Comments
 (0)