Fix parser translator tokens for backslashes in single-quoted strings and word arrays #3387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
force-pushed
the
parser-translator-tokens-line-cont-single-quotes
branch
from
387ae75 to
5bc3727
Compare
Earlopain
changed the title
kddnewton
requested changes
Jan 10, 2025
| end | ||
|
|
||
| # Determine if the string is part of a %-style array. | ||
| def word_array?(quote) |
Collaborator
There was a problem hiding this comment.
Suggested change
| def word_array?(quote) | |
| def percent_literal?(quote) |
If you don't mind, can you change this? CRuby internally calls %w a word array, so I want to make sure it's clear that this includes symbol lists as well.
Collaborator
Author
There was a problem hiding this comment.
Yeah, no problem
… and word arrays These are not line continuations. They either should be taken literally, or allow the word array to contain the following whitespace (newlines in this case) Before: ``` 0...1: tSTRING_BEG => "'" 1...12: tSTRING_CONTENT => "foobar\\\n" 12...16: tSTRING_CONTENT => "baz\n" 16...17: tSTRING_END => "'" 17...18: tNL => nil ``` After: ``` 0...1: tSTRING_BEG => "'" 1...6: tSTRING_CONTENT => "foo\\\n" 6...12: tSTRING_CONTENT => "bar\\\n" 12...16: tSTRING_CONTENT => "baz\n" 16...17: tSTRING_END => "'" 17...18: tNL => nil ```
Earlopain
force-pushed
the
parser-translator-tokens-line-cont-single-quotes
branch
from
5bc3727 to
b6554ad
Compare
kddnewton
approved these changes
Jan 11, 2025
Earlopain
deleted the
parser-translator-tokens-line-cont-single-quotes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Additionally, a trailing backslash in a word array is not a line continuation, but rather makes the following newline part of the string/symbol.