Skip to content

Commit a2e7683

Browse files
committed
Fix test has %a{implicitly-returns-nil}
`%a{implicitly-returns-nil}` cannot be checked to return `nil`
1 parent 7fbb8f5 commit a2e7683

File tree

1 file changed

+2
-21
lines changed

1 file changed

+2
-21
lines changed

test/stdlib/Array_test.rb

Lines changed: 2 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -155,8 +155,6 @@ def test_at
155155
[1,2,3], :at, 0
156156
assert_send_type "(ToInt) -> Integer",
157157
[1,2,3], :at, ToInt.new(0)
158-
assert_send_type "(ToInt) -> nil",
159-
[1,2,3], :at, ToInt.new(-5)
160158
end
161159

162160
def test_bsearch
@@ -269,11 +267,8 @@ def test_delete
269267
def test_delete_at
270268
assert_send_type "(Integer) -> Integer",
271269
[1,2,3], :delete_at, 2
272-
assert_send_type "(Integer) -> nil",
273-
[1,2,3], :delete_at, 100
274-
275-
assert_send_type "(ToInt) -> nil",
276-
[1,2,3], :delete_at, ToInt.new(300)
270+
assert_send_type "(ToInt) -> Integer",
271+
[1,2,3], :delete_at, ToInt.new(2)
277272
end
278273

279274
def test_delete_if
@@ -427,8 +422,6 @@ def test_find_index
427422
def test_first
428423
assert_send_type "() -> Integer",
429424
[1,2,3], :first
430-
assert_send_type "() -> nil",
431-
[], :first
432425

433426
assert_send_type "(Integer) -> Array[Integer]",
434427
[1,2,3], :first, 2
@@ -529,8 +522,6 @@ def test_keep_if
529522
def test_last
530523
assert_send_type "() -> Integer",
531524
[1,2,3], :last
532-
assert_send_type "() -> nil",
533-
[], :last
534525

535526
assert_send_type "(Integer) -> Array[Integer]",
536527
[1,2,3], :last, 2
@@ -558,8 +549,6 @@ def test_map!
558549
def test_max
559550
assert_send_type "() -> Integer",
560551
[1,2,3], :max
561-
assert_send_type "() -> nil",
562-
[], :max
563552

564553
assert_send_type "(Integer) -> Array[Integer]",
565554
[1,2,3], :max, 1
@@ -568,8 +557,6 @@ def test_max
568557

569558
assert_send_type "() { (Integer, Integer) -> Integer } -> Integer",
570559
[1,2,3], :max do |_, _| 1 end
571-
assert_send_type "() { (Integer, Integer) -> Integer } -> nil",
572-
[], :max do |_, _| 0 end
573560

574561
assert_send_type "(ToInt) { (Integer, Integer) -> Integer } -> Array[Integer]",
575562
[1,2,3], :max, ToInt.new(2) do |_, _| 0 end
@@ -758,8 +745,6 @@ def test_rotate!
758745
def test_sample
759746
assert_send_type "() -> Integer",
760747
[1,2,3], :sample
761-
assert_send_type "() -> nil",
762-
[], :sample
763748
assert_send_type "(random: Random) -> Integer",
764749
[1,2,3], :sample, random: Random.new(1)
765750
assert_send_type "(random: Rand) -> Integer",
@@ -817,8 +802,6 @@ def test_shuffle!
817802
def test_slice
818803
assert_send_type "(Integer) -> Integer",
819804
[1,2,3], :slice, 1
820-
assert_send_type "(ToInt) -> nil",
821-
[1,2,3], :slice, ToInt.new(11)
822805

823806
assert_send_type "(Integer, Integer) -> Array[Integer]",
824807
[1,2,3], :slice, 1, 2
@@ -834,8 +817,6 @@ def test_slice
834817
def test_slice!
835818
assert_send_type "(Integer) -> Integer",
836819
[1,2,3], :slice!, 1
837-
assert_send_type "(ToInt) -> nil",
838-
[1,2,3], :slice!, ToInt.new(11)
839820

840821
assert_send_type "(Integer, Integer) -> Array[Integer]",
841822
[1,2,3], :slice!, 1, 2

0 commit comments

Comments
 (0)