Fix gen_url for non-rdoc-ref links. Issue #56

Author: drbrain

History.txt

@@ -3,6 +3,7 @@
 * Bug fixes
   * Fix RDoc::Markup parser for a header followed by a non-text token.  Issue
     #56 by Adam Tait
+  * Fix RDoc::Markup::ToHtmlCrossref#gen_url for non-<tt>rdoc-ref</tt> links.
   * Fix bug report URL when rdoc crashes.
 
 === 3.9 / 2011-07-30

lib/rdoc/markup/to_html_crossref.rb

@@ -97,7 +97,7 @@ def handle_special_HYPERLINK special
   # RDoc::Markup::ToHtml to handle other schemes.
 
   def gen_url url, text
-    super unless url =~ /\Ardoc-ref:/
+    return super unless url =~ /\Ardoc-ref:/
 
     cross_reference $', text
   end

test/test_rdoc_markup_to_html_crossref.rb

@@ -25,6 +25,14 @@ def test_convert_HYPERLINK_rdoc_ref
     assert_equal "\n<p><a href=\"C1.html\">C1</a></p>\n", result
   end
 
+  def test_gen_url
+    assert_equal '<a href="C1.html">Some class</a>',
+                 @to.gen_url('rdoc-ref:C1', 'Some class')
+
+    assert_equal '<a href="http://example">HTTP example</a>',
+                 @to.gen_url('http://example', 'HTTP example')
+  end
+
   def test_handle_special_CROSSREF
     assert_equal "<a href=\"C2/C3.html\">C2::C3</a>", SPECIAL('C2::C3')
   end