lint: Remove unreachable code (#1137)

okuramasafumi · web-flow · commit a53287fce0a9 · 2024-12-08T23:14:14.000Z
This is an attempt to utilize RuboCop further. RuboCop was added in 9262fdd but only a few rules have been enabled. I believe we can utilize RuboCop more for better code quality, especially with Lint cops. This is the first step to enable other Lint cops. This commit also exclude some auto generated files.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -17,3 +17,6 @@ Layout/SpaceBeforeComma:
 
 Layout/SpaceAfterComma:
   Enabled: true
+
+Lint/UnreachableCode:
+  Enabled: true
diff --git a/lib/rdoc/rdoc.rb b/lib/rdoc/rdoc.rb
@@ -395,7 +395,6 @@ def parse_file filename
     $stderr.puts e.backtrace.join("\n\t") if $DEBUG_RDOC
 
     raise e
-    nil
   end
 
   ##

-Original file line number
+Diff line change
     $stderr.puts e.backtrace.join("\n\t") if $DEBUG_RDOC
     raise e
 -    nil
   end
   ##