Skip to content

Commit ed7c091

Browse files
unasukest0012
authored andcommitted
Rename to nesting_namespaces
1 parent ec240da commit ed7c091

File tree

3 files changed

+19
-19
lines changed

3 files changed

+19
-19
lines changed

lib/rdoc/code_object/class_module.rb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -298,19 +298,19 @@ def full_name
298298
##
299299
# Return array of full_name splitted by +::+.
300300

301-
def namespaces
301+
def nesting_namespaces
302302
@namespaces ||= full_name.split("::").reject(&:empty?)
303303
end
304304

305305
##
306-
# Return array of fully qualified namespaces.
306+
# Return array of fully qualified nesting namespaces.
307307
#
308308
# For example, if full_name is +A::B::C+, this method returns <code>["A", "A::B", "A::B::C"]</code>
309309

310-
def fully_qualified_namespaces
311-
return namespaces if namespaces.length < 2
312-
@fqns ||= namespaces.map.with_index do |_, i|
313-
namespaces[0..i].join("::")
310+
def fully_qualified_nesting_namespaces
311+
return nesting_namespaces if nesting_namespaces.length < 2
312+
@fqns ||= nesting_namespaces.map.with_index do |_, i|
313+
nesting_namespaces[0..i].join("::")
314314
end
315315
end
316316

lib/rdoc/generator/darkfish.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ def generate_class klass, template_file = nil
353353
asset_rel_prefix = rel_prefix + @asset_rel_path
354354
svninfo = get_svninfo(current)
355355

356-
breadcrumb = generate_namespaces_breadcrumb(current, rel_prefix)
356+
breadcrumb = generate_nesting_namespaces_breadcrumb(current, rel_prefix)
357357

358358
@title = "#{klass.type} #{klass.full_name} - #{@options.title}"
359359

@@ -833,18 +833,18 @@ def generate_ancestor_list(ancestors, klass)
833833

834834
private
835835

836-
def namespaces_to_class_modules klass
836+
def nesting_namespaces_to_class_modules klass
837837
tree = {}
838838

839-
klass.namespaces.zip(klass.fully_qualified_namespaces) do |ns, fqns|
839+
klass.nesting_namespaces.zip(klass.fully_qualified_nesting_namespaces) do |ns, fqns|
840840
tree[ns] = @store.classes_hash[fqns] || @store.modules_hash[fqns]
841841
end
842842

843843
tree
844844
end
845845

846-
def generate_namespaces_breadcrumb klass, rel_prefix
847-
namespaces_to_class_modules(klass).map do |namespace, class_module|
846+
def generate_nesting_namespaces_breadcrumb klass, rel_prefix
847+
nesting_namespaces_to_class_modules(klass).map do |namespace, class_module|
848848
path = class_module ? (rel_prefix + class_module.path).to_s : ""
849849
{ name: namespace, path: path, self: klass.full_name == class_module&.full_name }
850850
end

test/rdoc/test_rdoc_class_module.rb

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1526,26 +1526,26 @@ def test_update_extends_with_colons
15261526
assert_equal [a, c], @c1.extends
15271527
end
15281528

1529-
def test_namespaces
1529+
def test_nesting_namespaces
15301530
cm1 = RDoc::ClassModule.new "A"
1531-
assert_equal ["A"], cm1.namespaces
1531+
assert_equal ["A"], cm1.nesting_namespaces
15321532

15331533
cm2 = RDoc::ClassModule.new "A::B"
1534-
assert_equal ["A", "B"], cm2.namespaces
1534+
assert_equal ["A", "B"], cm2.nesting_namespaces
15351535

15361536
cm3 = RDoc::ClassModule.new "::A::B::C"
1537-
assert_equal ["A", "B", "C"], cm3.namespaces
1537+
assert_equal ["A", "B", "C"], cm3.nesting_namespaces
15381538
end
15391539

1540-
def test_fully_qualified_namespaces
1540+
def test_fully_qualified_nesting_namespaces
15411541
cm1 = RDoc::ClassModule.new "A"
1542-
assert_equal ["A"], cm1.fully_qualified_namespaces
1542+
assert_equal ["A"], cm1.fully_qualified_nesting_namespaces
15431543

15441544
cm2 = RDoc::ClassModule.new "A::B"
1545-
assert_equal ["A", "A::B"], cm2.fully_qualified_namespaces
1545+
assert_equal ["A", "A::B"], cm2.fully_qualified_nesting_namespaces
15461546

15471547
cm3 = RDoc::ClassModule.new "::A::B::C"
1548-
assert_equal ["A", "A::B", "A::B::C"], cm3.fully_qualified_namespaces
1548+
assert_equal ["A", "A::B", "A::B::C"], cm3.fully_qualified_nesting_namespaces
15491549
end
15501550

15511551
class TestRDocClassModuleMixins < XrefTestCase

0 commit comments

Comments
 (0)