Skip to content

Fix erb linting errors and remove unnecessary code #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2025
+4 −8
Merged

Fix erb linting errors and remove unnecessary code #1449

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63f3066
Fix erb linting errors and remove unused code
st0012 Nov 14, 2025
814fac2
Update lib/rdoc/generator/template/darkfish/table_of_contents.rhtml
st0012 Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions lib/rdoc/generator/template/darkfish/_head.rhtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,8 @@
<meta name="description" content="<%= h "#{file.page_name}: #{excerpt(file.comment)}" %>">
<%- elsif @title %>
<meta name="keywords" content="ruby,documentation,<%= h @title %>">

<%- if @options.main_page and
main_page = @files.find { |f| f.full_name == @options.main_page } then %>
<meta name="description" content="<%= h "#{@title}: #{excerpt(main_page.comment)}" %>">
<%- else %>
<meta name="description" content="Documentation for <%= h @title %>">
<%- end %>
<% description = @main_page ? "#{@title}: #{excerpt(@main_page.comment)}" : "Documentation for #{@title}" %>
Copy link
Member Author

@st0012 st0012 Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@main_page is already computed in the generate_index method.

<meta name="description" content="<%= h description %>">
<%- end %>

<%- if canonical_url = @options.canonical_root %>
Expand Down
1 change: 1 addition & 0 deletions lib/rdoc/generator/template/darkfish/_sidebar_search.rhtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<input id="search-field" role="combobox" aria-label="Search"
aria-autocomplete="list" aria-controls="search-results"
type="text" name="search" placeholder="Search (/) for a class, method, ..." spellcheck="false"
autocomplete="off"
title="Type to search, Up and Down to navigate, Enter to load">
</div>

Expand Down
2 changes: 1 addition & 1 deletion lib/rdoc/generator/template/darkfish/table_of_contents.rhtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
unless table.empty? then %>
<ul>
<%- table.each do |item| %>
<%- label = item.respond_to?(:label) ? item.label(klass) : item.aref %>
<%- label = item.respond_to?(:label) ? item.label(klass) : item.aref %>
<li><a href="<%= klass.path %>#<%= label %>"><%= item.plain_html %></a></li>
<%- end %>
</ul>
Expand Down
Loading