Skip to content

Commit 06cf574

Browse files
authored
Merge pull request #328 from Shopify/rwstauner/rails-without-yjit
Don't let Rails auto-enable YJIT when benchmarking CRuby baseline
2 parents f2b3c35 + 1c7effa commit 06cf574

File tree

3 files changed

+9
-0
lines changed

3 files changed

+9
-0
lines changed

benchmarks/erubi-rails/config/environments/production.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,4 +92,7 @@
9292

9393
# yjit-bench configurations
9494
config.active_record.sqlite3_production_warning = false
95+
# If we want to benchmark with YJIT then it has already been enabled by command line arguments.
96+
# If we are benchmarking CRuby without YJIT don't enable it even if this build has it.
97+
config.yjit = false
9598
end

benchmarks/lobsters/config/environments/production.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,4 +91,7 @@
9191
config.active_record.sqlite3_production_warning = false
9292
config.logger = nil
9393
config.secret_key_base = 'in general secret should not be in the git repo but this is a benchmark'
94+
# If we want to benchmark with YJIT then it has already been enabled by command line arguments.
95+
# If we are benchmarking CRuby without YJIT don't enable it even if this build has it.
96+
config.yjit = false
9497
end

benchmarks/railsbench/config/environments/production.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,4 +94,7 @@
9494
config.active_record.sqlite3_production_warning = false
9595
config.logger = nil
9696
config.secret_key_base = 'in general secret should not be in the git repo but this is a benchmark'
97+
# If we want to benchmark with YJIT then it has already been enabled by command line arguments.
98+
# If we are benchmarking CRuby without YJIT don't enable it even if this build has it.
99+
config.yjit = false
97100
end

0 commit comments

Comments
 (0)