Move number formatting to a method

Author: rwstauner

harness/harness-common.rb

@@ -13,6 +13,18 @@
 # Seed the global random number generator for repeatability between runs
 Random.srand(1337)
 
+def format_number(num)
+  num.to_s.split(".").tap do |a|
+    # Insert comma separators but only in the whole number portion (a[0]).
+    # Look for "-?" at the end to preserve any leading minus sign that may be on the beginning.
+    a[0] = a[0].reverse.scan(/\d{1,3}-?/).join(",").reverse
+
+    # Add a space when positive so that if there is ever a negative
+    # the first digit will line up.
+    a[0].prepend(" ") unless a[0].start_with?("-")
+  end.join(".")
+end
+
 def run_cmd(*args)
   puts "Command: #{args.join(" ")}"
   system(*args)
@@ -114,7 +126,7 @@ def return_results(warmup_iterations, bench_iterations)
   if yjit_stats
     yjit_bench_results["yjit_stats"] = yjit_stats
 
-    formatted_stats = proc { |key| "%10s" % yjit_stats[key].to_s.split(".").tap { |a| a[0] = a[0].reverse.scan(/\d{1,3}/).join(",").reverse }.join(".") }
+    formatted_stats = proc { |key| "%10s" % format_number(yjit_stats[key]) }
     yjit_stats_keys = [
       *ENV.fetch("YJIT_BENCH_STATS", "").split(",").map(&:to_sym),
       :inline_code_size,

harness/harness.rb

@@ -59,17 +59,8 @@ def run_benchmark(_num_itrs_hint, &block)
 
     yjit_stats&.each do |key, old_value|
       new_value = RubyVM::YJIT.runtime_stats(key)
-
-      # Insert comma separators but only in the whole number portion.
-      diff = (new_value - old_value).to_s.split(".").tap do |a|
-        # Preserve any leading minus sign that may be on the beginning.
-        a[0] = a[0].reverse.scan(/\d{1,3}-?/).join(",").reverse
-        # Add a space when positive so that if there is ever a negative
-        # the first digit will line up.
-        a[0].prepend(" ") unless a[0].start_with?("-")
-      end.join(".")
-
-      itr_str << " %#{key.size}s" % diff
+      diff = (new_value - old_value)
+      itr_str << " %#{key.size}s" % format_number(diff)
       yjit_stats[key] = new_value
     end