Skip to content

Commit 2fc5550

Browse files
Remove --ractor-only
The way to run Ractor benchmarks is using --category=ractor # All ractor benchmarks --category=ractor-only # Only custom ractor benchmarks in benchmarks-ractor
1 parent 2dd7b27 commit 2fc5550

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

.github/workflows/test.yml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,16 @@ jobs:
3737
MIN_BENCH_TIME: '0'
3838
continue-on-error: ${{ matrix.continue-on-error || false }}
3939

40-
- name: Test run_benchmarks.rb --ractor-only
41-
run: ./run_benchmarks.rb --ractor-only
40+
- name: Test run_benchmarks.rb - Ractors
41+
run: ./run_benchmarks.rb --category=ractor
42+
env:
43+
WARMUP_ITRS: '1'
44+
MIN_BENCH_ITRS: '1'
45+
MIN_BENCH_TIME: '0'
46+
continue-on-error: ${{ matrix.continue-on-error || false }}
47+
48+
- name: Test run_benchmarks.rb - Ractor Only
49+
run: ./run_benchmarks.rb --category=ractor-only
4250
env:
4351
WARMUP_ITRS: '1'
4452
MIN_BENCH_ITRS: '1'

run_benchmarks.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -425,10 +425,6 @@ def run_benchmarks(ruby:, ruby_description:, categories:, name_filters:, out_pat
425425
args.categories += ["headline"]
426426
end
427427

428-
opts.on("--ractor-only", "ractor-only benchmarks (benchmarks/ractor/*.rb) will be run") do
429-
args.categories = ["ractor-only"]
430-
end
431-
432428
opts.on("--name_filters=x,y,z", Array, "when given, only benchmarks with names that contain one of these strings will run") do |list|
433429
args.name_filters = list
434430
end

0 commit comments

Comments
 (0)