Skip to content

Commit 6d43a4c

Browse files
committed
Add continue-on-error to the workflow
TruffleRuby has been failing on random benchmarks in the last three builds: https://github.com/ruby/ruby-bench/actions/runs/17961477542/job/51085511584 https://github.com/ruby/ruby-bench/actions/runs/17961695913/job/51086136742 https://github.com/ruby/ruby-bench/actions/runs/17967402033/job/51102476785 This job has so far failed when TruffleRuby had a bug, not when ruby-bench introduced an incompatibility with TruffleRuby. This is not a repository for testing TruffleRuby, so testing benchmarks with CRuby seems enough for most of the time. You can still see the history of GitHub Actions in case some change in ruby-bench permanently breaks the build for TruffleRuby. I think it's enough for maintaining the TruffleRuby support. We often don't write CRuby-specific code other than YJIT/ZJIT integration anyway.
1 parent ef21749 commit 6d43a4c

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

.github/workflows/test.yml

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ jobs:
1616
- ruby: ruby
1717
- ruby: head
1818
- ruby: truffleruby
19-
skip: protoboeuf-encode ruby-lsp shipit hexapdf mail rubocop
19+
# TruffleRuby has randomly failed on different benchmarks
20+
continue-on-error: true
2021
if: ${{ github.event_name != 'schedule' || github.repository == 'ruby/ruby-bench' }}
2122
steps:
2223
- uses: actions/checkout@v3
@@ -29,16 +30,12 @@ jobs:
2930
run: ruby test/benchmarks_test.rb
3031

3132
- name: Test run_benchmarks.rb
32-
run: |
33-
for benchmark in $SKIP_BENCHMARKS; do
34-
rm -rf "benchmarks/${benchmark}.rb" "benchmarks/${benchmark}/"
35-
done
36-
./run_benchmarks.rb
33+
run: ./run_benchmarks.rb
3734
env:
3835
WARMUP_ITRS: '1'
3936
MIN_BENCH_ITRS: '1'
4037
MIN_BENCH_TIME: '0'
41-
SKIP_BENCHMARKS: ${{ matrix.skip }}
38+
continue-on-error: ${{ matrix.continue-on-error || false }}
4239

4340
- name: Test run_benchmarks.rb --graph
4441
run: |

0 commit comments

Comments
 (0)