Make most benchmarks Ractor compatible

Co-Authored-By: Luke Gruber <[email protected]>
Co-Authored-By: Étienne Barrié <[email protected]>

Author: 3 people

.gitignore

@@ -3,6 +3,7 @@
 *.csv
 *.dump
 logs*
+benchmarks/*/data/
 
 __pycache__
 /benchmarks/discourse

benchmarks/30k_ifelse.rb

@@ -1,3 +1,11 @@
+require_relative '../harness/loader'
+if ENV["YJIT_BENCH_RACTOR_HARNESS"]
+  eval_recv = Object.new
+  eval_meth = :instance_eval
+else
+  eval_recv = nil
+end
+
 def fun_l0_n0(x)
   if (x < 1)
     fun_l1_n310(x)
@@ -239998,23 +240006,29 @@ def fun_l29_n999(x)
   end
 end
 
-@a = 0
-@b = 0
-@c = 0
-@d = 0
-
-@count = 0
 def inc(x)
   @count += 1
 end
 
-@x = 0
-
-require_relative '../harness/loader'
-
 INTERNAL_ITRS = Integer(ENV.fetch("INTERNAL_ITRS", 200))
 
-run_benchmark(30) do
+main_obj = ENV["YJIT_BENCH_RACTOR_HARNESS"] ? eval_recv : nil
+run_benchmark(30, ractor_args: [main_obj]) do |num_rs,  selv|
+  if selv
+    recv = selv
+    recv_meth = :instance_eval
+  else
+    recv = 1
+    recv_meth = :times
+  end
+  recv.send(recv_meth) do
+  @a = 0
+  @b = 0
+  @c = 0
+  @d = 0
+
+  @count = 0
+  @x = 0
   INTERNAL_ITRS.times do
     @x = (@x < 1)? 1:0
     fun_l0_n0(@x)
@@ -241017,5 +241031,6 @@ def inc(x)
     fun_l0_n997(@x)
     fun_l0_n998(@x)
     fun_l0_n999(@x)
+    end
   end
 end

benchmarks/attr_accessor.rb

@@ -34,8 +34,9 @@ def get_value_loop
   end
 end
 
-obj = TheClass.new
+OBJ = TheClass.new
+Ractor.make_shareable(OBJ)
 
-run_benchmark(850) do
-  obj.get_value_loop
+run_benchmark(10) do
+  OBJ.get_value_loop
 end

benchmarks/binarytrees/benchmark.rb

@@ -16,15 +16,18 @@ def bottom_up_tree(depth)
   [bottom_up_tree(depth), bottom_up_tree(depth)]
 end
 
-max_depth = 14
-min_depth = 4
+MAX_DEPTH = 14
+MIN_DEPTH = 4
 
-max_depth = min_depth + 2 if min_depth + 2 > max_depth
-stretch_depth = max_depth + 1
+MAX_DEPTH = MIN_DEPTH + 2 if MIN_DEPTH + 2 > MAX_DEPTH
+STRETCH_DEPTH = MAX_DEPTH + 1
 
 require_relative '../../harness/loader'
 
 run_benchmark(60) do
+  max_depth = MAX_DEPTH
+  min_depth = MIN_DEPTH
+  stretch_depth = STRETCH_DEPTH
   stretch_tree = bottom_up_tree(stretch_depth)
   stretch_tree = nil
 

benchmarks/blurhash/benchmark.rb

@@ -46,7 +46,7 @@ def [](from, len)
       end
     end
 
-    CHARACTERS = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz#$%*+,-.:;=?@[]^_{|}~".bytes
+    CHARACTERS = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz#$%*+,-.:;=?@[]^_{|}~".bytes.freeze
 
     def self.sRGBToLinear(value)
       v = value.to_f / 255
@@ -176,8 +176,8 @@ def blurHashForPixels(xComponents, yComponents, width, height, rgb, bytesPerRow)
 
 FILE = File.join(__dir__, "test.bin")
 
-array = File.read(FILE).bytes
+Ractor.make_shareable(ARRAY = File.read(FILE).bytes)
 
 run_benchmark(10) do
-  Blurhash.encode_rb(204, 204, array)
+  Blurhash.encode_rb(204, 204, ARRAY)
 end

benchmarks/erubi/benchmark.rb

@@ -44,18 +44,26 @@ def check_result_size(result)
 source = generate_source(template)
 
 # Create a method with the generated source
-eval "# frozen_string_literal: true\ndef run_erb; #{source}; end"
+eval <<RUBY
+# frozen_string_literal: true
+class ErbRenderer
+  def initialize(values)
+    @values = values
+  end
+  def run_erb
+    #{source}
+  end
+end
+RUBY
 
 # This is taken from actual "gem server" data
-@values = JSON.load(File.read "gem_specs.json")
-result = run_erb
-check_result_size(result)
+VALUES = JSON.load(File.read "gem_specs.json")
+Ractor.make_shareable(VALUES)
+check_result_size(ErbRenderer.new(VALUES).run_erb)
 
 run_benchmark(50) do
   250.times do
-    #result = eval source
-    result = run_erb
-    #check_result_size(result)
-
+    ErbRenderer.new(VALUES).run_erb
+    #.then { |result| check_result_size(result) }
   end
 end

benchmarks/fannkuchredux/benchmark.rb

@@ -54,12 +54,12 @@ def fannkuch(n)
 end
 
 #n = (ARGV[0] || 1).to_i
-n = 9 # Benchmarks Game uses n = 12, but it's too slow
+N = 9 # Benchmarks Game uses n = 12, but it's too slow
 
 require_relative '../../harness/loader'
 
 run_benchmark(10) do
-  sum, flips = fannkuch(n)
+  sum, flips = fannkuch(N)
 
   if sum != 8629
     raise RuntimeError, "incorrect sum: #{sum}"

benchmarks/getivar.rb

@@ -32,8 +32,8 @@ def get_value_loop
   end
 end
 
-obj = TheClass.new
+OBJ = TheClass.new.freeze
 
 run_benchmark(850) do
-  obj.get_value_loop
+ OBJ.get_value_loop
 end

benchmarks/graphql/benchmark.rb

@@ -5,10 +5,21 @@
 
 require "graphql"
 
-data = File.read "negotiate.gql"
+DATA = Ractor.make_shareable(File.read "negotiate.gql")
+
+if ENV["YJIT_BENCH_RACTOR_HARNESS"]
+  GraphQL.default_parser
+  Ractor.make_shareable(GraphQL::Tracing::NullTrace)
+  GraphQL::Language::Lexer.constants.each do |constant|
+    Ractor.make_shareable(GraphQL::Language::Lexer.const_get(constant))
+  end
+  GraphQL::Language::Parser.constants.each do |constant|
+    Ractor.make_shareable(GraphQL::Language::Parser.const_get(constant))
+  end
+end
 
 run_benchmark(10) do
   10.times do |i|
-    GraphQL.parse data
+    GraphQL.parse DATA
   end
 end

benchmarks/hexapdf/benchmark.rb

@@ -18,7 +18,14 @@
 
 Dir["/tmp/hexapdf-result*.pdf"].each { |file| FileUtils.rm file }
 
-index = 0
+if ENV["YJIT_BENCH_RACTOR_HARNESS"]
+  Ractor.make_shareable(HexaPDF::DefaultDocumentConfiguration)
+  Ractor.make_shareable(HexaPDF::GlobalConfiguration)
+  # TODO... still doesn't work
+end
+
+iter = 0
+
 run_benchmark(10) do
   ## TTF benchmark (v. slow)
   #HexaPDF::Composer.create(OUT_FILENAME, page_size: [0, 0, WIDTH, HEIGHT], margin: 0) do |pdf|
@@ -28,8 +35,8 @@
   #end
 
   # Non-TTF benchmark
-  index += 1
-  out_filename = "/tmp/hexapdf-result-#{ "%03d" % index }.pdf"
+  iter += 1
+  out_filename = "/tmp/hexapdf-result-#{ "%03d" % iter }.pdf"
 
 
   composer = HexaPDF::Composer.new(page_size: [0, 0, WIDTH, HEIGHT], margin: 0)