You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Profiling the lobsters benchmark I'm seeing a fairly large time spent
joining tags in TaggedLogger.
That intruigued me, and by digging I noticed the requests UUIDs kept
being appended but never removed.
So for every single request we have one more tag, this is skewing
the benchmark a bit, as we spend much more time than we should in
logging.
Copy file name to clipboardExpand all lines: benchmarks/lobsters/benchmark.rb
+1Lines changed: 1 addition & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -47,6 +47,7 @@
47
47
putsresponse_array.inspect
48
48
raise"HTTP status is #{response_array.first} instead of 200 for req #{idx}/#{generator.routes.size}, #{path.inspect}. Is the benchmark app properly set up? See README.md."
49
49
end
50
+
response_array.last.close# Response might be a Rack::BodyProxy and MUST be closed.
0 commit comments