Add attr_accessor benchmark #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0kubun
reviewed
Jul 15, 2025
Comment on lines
+7
to
+9
| @v0 = 1 | ||
| @v1 = 2 | ||
| @v3 = 3 |
There was a problem hiding this comment.
This makes me uncomfortable lol
I think you meant either
Suggested change
| @v0 = 1 | |
| @v1 = 2 | |
| @v3 = 3 | |
| @v0 = 1 | |
| @v1 = 2 | |
| @v2 = 3 |
or
Suggested change
| @v0 = 1 | |
| @v1 = 2 | |
| @v3 = 3 | |
| @v1 = 1 | |
| @v2 = 2 | |
| @v3 = 3 |
There was a problem hiding this comment.
and I guess it was just copied from the getivar benchmark. let's just fix both
There was a problem hiding this comment.
Yeah I just deleted the @. Oop
k0kubun
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.