Add ZJIT to run_benchmarks.rb #370
Closed
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This at least will compare against ZJIT if present.
rwstauner
reviewed
Jul 18, 2025
| if have_yjit?(RbConfig.ruby) | ||
| args.executables["interp"] = [RbConfig.ruby] | ||
| args.executables["yjit"] = [RbConfig.ruby, "--yjit", *args.yjit_opts.shellsplit] | ||
| elsif have_zjit?(RbConfig.ruby) |
There was a problem hiding this comment.
Do we want zjit checked first, or yjit first?
Are we generally building rubies with both, or just one of them?
There was a problem hiding this comment.
The default is still YJIT-only, and I opt-in the ZJIT-YJIT-combo build locally. So it might make sense to put ZJIT first (otherwise ZJIT is never going to be benchmarked for such people). Though I don't run run_benchmarks.rb with the Ruby to be benchmarked, so I'm fine with either of these.
k0kubun
approved these changes
Jul 21, 2025
rwstauner
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This at least will compare against ZJIT if present.