Skip to content

Commit 0c329b1

Browse files
JS::Object#[] is already tested in unit/test_object.rb
1 parent 02d8dda commit 0c329b1

File tree

2 files changed

+6
-15
lines changed

2 files changed

+6
-15
lines changed

packages/npm-packages/ruby-wasm-wasi/test/js_from_rb.test.ts

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -10,21 +10,6 @@ describe("Manipulation of JS from Ruby", () => {
1010
expect(result.toString()).toBe("true");
1111
});
1212

13-
test.each([
14-
{ expr: "JS.global[:Object]", result: Object },
15-
{ expr: "JS.global[:Object][:keys]", result: Object.keys },
16-
{ expr: "JS.global[:Object][:unknown_key]", result: undefined },
17-
// reflect `Reflect` itself
18-
{ expr: "JS.global[:Reflect]", result: Reflect },
19-
])(`JS::Object#[] (%s)`, async (props) => {
20-
const vm = await initRubyVM();
21-
const result = vm.eval(`
22-
require "js"
23-
${props.expr}
24-
`);
25-
expect(result.toJS()).toBe(props.result);
26-
});
27-
2813
test.each([
2914
{ expr: "", result: undefined },
3015
{ expr: "return undefined", result: undefined },

packages/npm-packages/ruby-wasm-wasi/test/unit/test_object.rb

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,8 @@ def test_member_get
209209
assert_equal 42.to_s, object["foo"].to_s
210210

211211
assert_raise(JS::Error) { JS::Undefined[:foo] }
212+
213+
assert_equal JS::Undefined.to_s, object["bar"].to_s
212214
end
213215

214216
def test_member_set
@@ -221,6 +223,10 @@ def test_member_set
221223
assert_equal 42.to_s, object["foo"].to_s
222224

223225
assert_raise(JS::Error) { JS::Undefined[:foo] = 42 }
226+
227+
# Create new property
228+
object["bar"] = 41
229+
assert_equal 41.to_s, object["bar"].to_s
224230
end
225231

226232
def test_member_set_with_stress_gc

0 commit comments

Comments
 (0)