Skip to content

Commit f2212a4

Browse files
Remove a reference to version.rb outside of the js gem
1 parent c1be033 commit f2212a4

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

packages/gems/js/js.gemspec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
# frozen_string_literal: true
22

3-
require_relative "../../../lib/ruby_wasm/version"
3+
require_relative "lib/js/version"
44

55
Gem::Specification.new do |spec|
66
spec.name = "js"
7-
spec.version = RubyWasm::VERSION
7+
spec.version = JS::VERSION
88
spec.authors = ["Yuta Saito"]
99
spec.email = ["[email protected]"]
1010

packages/gems/js/lib/js/version.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
module JS
2+
VERSION = "2.4.1"
3+
end

tasks/version.rake

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,17 +22,16 @@ def bump_version_npm_package(package, version)
2222
end
2323
end
2424

25-
def bump_version_rb(lib, version)
26-
lib_dir = "#{Dir.pwd}/lib/#{lib}"
27-
version_rb = "#{lib_dir}/version.rb"
25+
def bump_version_rb(version_rb, version)
2826
version_rb_content = File.read(version_rb)
2927
version_rb_content.gsub!(/VERSION = ".+"/, "VERSION = \"#{version}\"")
3028
File.write(version_rb, version_rb_content)
3129
end
3230

3331
task :bump_version, %i[version] do |t, args|
3432
version = args[:version] or raise "version is required"
35-
bump_version_rb("ruby_wasm", version)
33+
bump_version_rb("lib/ruby_wasm/version.rb", version)
34+
bump_version_rb("packages/gems/js/lib/js/version.rb", version)
3635
NPM_PACKAGES.each { |pkg| bump_version_npm_package(pkg[:name], version) }
3736
# Update ./package-lock.json
3837
sh "npm install"

0 commit comments

Comments
 (0)