Skip to content

Commit 247e082

Browse files
Merge pull request #7256 from rubygems/bump-rake
Bump rake version used by tests
2 parents 2c02993 + 1ea4bfa commit 247e082

File tree

14 files changed

+41
-37
lines changed

14 files changed

+41
-37
lines changed

bundler/spec/commands/lock_spec.rb

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
c.checksum repo, "activesupport", "2.3.2"
2020
c.checksum repo, "foo", "1.0"
2121
c.checksum repo, "rails", "2.3.2"
22-
c.checksum repo, "rake", "13.0.1"
22+
c.checksum repo, "rake", rake_version
2323
c.checksum repo, "weakling", "0.0.3"
2424
end
2525

@@ -42,8 +42,8 @@
4242
actionpack (= 2.3.2)
4343
activerecord (= 2.3.2)
4444
activeresource (= 2.3.2)
45-
rake (= 13.0.1)
46-
rake (13.0.1)
45+
rake (= #{rake_version})
46+
rake (#{rake_version})
4747
weakling (0.0.3)
4848
4949
PLATFORMS
@@ -201,7 +201,7 @@
201201
c.checksum repo, "activesupport", "2.3.2"
202202
c.checksum repo, "foo", "1.0"
203203
c.checksum repo, "rails", "2.3.2"
204-
c.checksum repo, "rake", "13.0.1"
204+
c.checksum repo, "rake", rake_version
205205
c.checksum repo, "weakling", "0.0.3"
206206
end
207207

@@ -224,8 +224,8 @@
224224
actionpack (= 2.3.2)
225225
activerecord (= 2.3.2)
226226
activeresource (= 2.3.2)
227-
rake (= 13.0.1)
228-
rake (13.0.1)
227+
rake (= #{rake_version})
228+
rake (#{rake_version})
229229
weakling (0.0.3)
230230
231231
PLATFORMS
@@ -245,11 +245,11 @@
245245
end
246246

247247
it "update specific gems using --update" do
248-
lockfile @lockfile.gsub("2.3.2", "2.3.1").gsub("13.0.1", "10.0.1")
248+
lockfile @lockfile.gsub("2.3.2", "2.3.1").gsub(rake_version, "10.0.1")
249249

250250
bundle "lock --update rails rake"
251251

252-
expect(read_lockfile).to eq(remove_checksums_from_lockfile(@lockfile, "(2.3.2)", "(13.0.1)"))
252+
expect(read_lockfile).to eq(remove_checksums_from_lockfile(@lockfile, "(2.3.2)", "(#{rake_version})"))
253253
end
254254

255255
it "preserves unknown checksum algorithms" do
@@ -315,7 +315,7 @@
315315

316316
bundle "lock --update rake --verbose"
317317
expect(out).to match(/Writing lockfile to.+lock/)
318-
expect(lockfile).to include("rake (13.0.1)")
318+
expect(lockfile).to include("rake (#{rake_version})")
319319
end
320320

321321
it "errors when updating a missing specific gems using --update" do
@@ -1005,7 +1005,7 @@
10051005
c.checksum repo, "activesupport", "2.3.2"
10061006
c.checksum repo, "foo", "1.0"
10071007
c.checksum repo, "rails", "2.3.2"
1008-
c.checksum repo, "rake", "13.0.1"
1008+
c.checksum repo, "rake", rake_version
10091009
c.checksum repo, "weakling", "0.0.3"
10101010
end
10111011

@@ -1028,8 +1028,8 @@
10281028
actionpack (= 2.3.2)
10291029
activerecord (= 2.3.2)
10301030
activeresource (= 2.3.2)
1031-
rake (= 13.0.1)
1032-
rake (13.0.1)
1031+
rake (= #{rake_version})
1032+
rake (#{rake_version})
10331033
weakling (0.0.3)
10341034
10351035
PLATFORMS
@@ -1059,7 +1059,7 @@
10591059
c.checksum repo, "activesupport", "2.3.2"
10601060
c.no_checksum "foo", "2.0"
10611061
c.checksum repo, "rails", "2.3.2"
1062-
c.checksum repo, "rake", "13.0.1"
1062+
c.checksum repo, "rake", rake_version
10631063
c.checksum repo, "weakling", "0.0.3"
10641064
end
10651065

@@ -1082,8 +1082,8 @@
10821082
actionpack (= 2.3.2)
10831083
activerecord (= 2.3.2)
10841084
activeresource (= 2.3.2)
1085-
rake (= 13.0.1)
1086-
rake (13.0.1)
1085+
rake (= #{rake_version})
1086+
rake (#{rake_version})
10871087
weakling (0.0.3)
10881088
10891089
PLATFORMS

bundler/spec/commands/newgem_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -456,7 +456,7 @@ def bundle_exec_standardrb
456456

457457
prepare_gemspec(bundled_app("newgem", "newgem.gemspec"))
458458

459-
gems = ["rake-13.0.1"]
459+
gems = ["rake-#{rake_version}"]
460460
path = Bundler.feature_flag.default_install_uses_path? ? local_gem_path(base: bundled_app("newgem")) : system_gem_path
461461
system_gems gems, path: path
462462
bundle "exec rake build", dir: bundled_app("newgem")
@@ -649,7 +649,7 @@ def create_temporary_dir(dir)
649649
it "runs rake without problems" do
650650
bundle "gem #{gem_name}"
651651

652-
system_gems ["rake-13.0.1"]
652+
system_gems ["rake-#{rake_version}"]
653653

654654
rakefile = <<~RAKEFILE
655655
task :default do

bundler/spec/commands/show_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
it "prints path of all gems in bundle sorted by name" do
5858
bundle "show --paths"
5959

60-
expect(out).to include(default_bundle_path("gems", "rake-13.0.1").to_s)
60+
expect(out).to include(default_bundle_path("gems", "rake-#{rake_version}").to_s)
6161
expect(out).to include(default_bundle_path("gems", "rails-2.3.2").to_s)
6262

6363
# Gem names are the last component of their path.

bundler/spec/install/gemfile/gemspec_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ def x64_mingw_checksums(checksums)
147147
build_lib("foo", path: tmp.join("foo")) do |s|
148148
s.write("Gemfile", "source '#{file_uri_for(gem_repo1)}'\ngemspec")
149149
s.add_dependency "actionpack", "=2.3.2"
150-
s.add_development_dependency "rake", "=13.0.1"
150+
s.add_development_dependency "rake", rake_version
151151
end
152152

153153
bundle "install", dir: tmp.join("foo")

bundler/spec/install/gemfile/path_spec.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -771,26 +771,26 @@
771771

772772
build_lib "foo", "1.0", path: lib_path("foo") do |s|
773773
s.add_dependency "rack"
774-
s.add_dependency "rake", "13.0.1"
774+
s.add_dependency "rake", rake_version
775775
end
776776

777777
bundle "install"
778778

779-
checksums.checksum gem_repo1, "rake", "13.0.1"
779+
checksums.checksum gem_repo1, "rake", rake_version
780780

781781
expect(lockfile).to eq <<~G
782782
PATH
783783
remote: #{lib_path("foo")}
784784
specs:
785785
foo (1.0)
786786
rack
787-
rake (= 13.0.1)
787+
rake (= #{rake_version})
788788
789789
GEM
790790
remote: #{file_uri_for(gem_repo1)}/
791791
specs:
792792
rack (0.9.1)
793-
rake (13.0.1)
793+
rake (#{rake_version})
794794
795795
PLATFORMS
796796
#{lockfile_platforms}

bundler/spec/install/gems/compact_index_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1050,7 +1050,7 @@ def start
10501050
source "#{source_uri}"
10511051
gem "rails"
10521052
G
1053-
deps = [Gem::Dependency.new("rake", "= 13.0.1"),
1053+
deps = [Gem::Dependency.new("rake", "= #{rake_version}"),
10541054
Gem::Dependency.new("actionpack", "= 2.3.2"),
10551055
Gem::Dependency.new("activerecord", "= 2.3.2"),
10561056
Gem::Dependency.new("actionmailer", "= 2.3.2"),

bundler/spec/lock/lockfile_spec.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -873,7 +873,7 @@
873873
c.checksum gem_repo2, "activeresource", "2.3.2"
874874
c.checksum gem_repo2, "activesupport", "2.3.2"
875875
c.checksum gem_repo2, "rails", "2.3.2"
876-
c.checksum gem_repo2, "rake", "13.0.1"
876+
c.checksum gem_repo2, "rake", rake_version
877877
end
878878

879879
expect(lockfile).to eq <<~G
@@ -894,8 +894,8 @@
894894
actionpack (= 2.3.2)
895895
activerecord (= 2.3.2)
896896
activeresource (= 2.3.2)
897-
rake (= 13.0.1)
898-
rake (13.0.1)
897+
rake (= #{rake_version})
898+
rake (#{rake_version})
899899
900900
PLATFORMS
901901
#{lockfile_platforms}

bundler/spec/runtime/inline_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -421,11 +421,11 @@ def confirm(msg, newline = nil)
421421
script <<-RUBY
422422
gemfile(true) do
423423
source "#{file_uri_for(gem_repo1)}"
424-
gem "rake", "~> 13.0"
424+
gem "rake", "#{rake_version}"
425425
end
426426
RUBY
427427

428-
expect(out).to include("Installing rake 13.0")
428+
expect(out).to include("Installing rake #{rake_version}")
429429
expect(out).not_to include("was 11.3.0")
430430
expect(err).to be_empty
431431
end

bundler/spec/runtime/setup_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ def clean_load_path(lp)
158158
"/gems/actionpack-2.3.2/lib",
159159
"/gems/actionmailer-2.3.2/lib",
160160
"/gems/activesupport-2.3.2/lib",
161-
"/gems/rake-13.0.1/lib"
161+
"/gems/rake-#{rake_version}/lib"
162162
)
163163
end
164164

bundler/spec/support/builders.rb

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,10 @@ def pl(platform)
1717
Gem::Platform.new(platform)
1818
end
1919

20+
def rake_version
21+
"13.1.0"
22+
end
23+
2024
def build_repo1
2125
rake_path = Dir["#{Path.base_system_gems}/**/rake*.gem"].first
2226

@@ -49,7 +53,7 @@ def build_repo1
4953

5054
build_gem "rails", "2.3.2" do |s|
5155
s.executables = "rails"
52-
s.add_dependency "rake", "13.0.1"
56+
s.add_dependency "rake", rake_version
5357
s.add_dependency "actionpack", "2.3.2"
5458
s.add_dependency "activerecord", "2.3.2"
5559
s.add_dependency "actionmailer", "2.3.2"

0 commit comments

Comments
 (0)