Skip to content

Commit 3a6293f

Browse files
martinemdedeivid-rodriguez
authored andcommitted
Merge pull request #7431 from ohbarye/patch-2
(cherry picked from commit d479be0)
1 parent ccbe56c commit 3a6293f

File tree

3 files changed

+0
-46
lines changed

3 files changed

+0
-46
lines changed

bundler/lib/bundler/cli/gem.rb

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ def initialize(options, gem_name, thor)
3232

3333
validate_ext_name if @extension
3434
validate_rust_builder_rubygems_version if @extension == "rust"
35-
travis_removal_info
3635
end
3736

3837
def run
@@ -455,19 +454,6 @@ def standard_version
455454
"1.3"
456455
end
457456

458-
# TODO: remove at next minor release
459-
def travis_removal_info
460-
if options[:ci] == "travis"
461-
Bundler.ui.error "Support for Travis CI was removed from gem skeleton generator."
462-
exit 1
463-
end
464-
465-
if Bundler.settings["gem.ci"] == "travis"
466-
Bundler.ui.error "Support for Travis CI was removed from gem skeleton generator, but it is present in bundle config. Please configure another provider using `bundle config set gem.ci SERVICE` (where SERVICE is one of github/gitlab/circle) or unset configuration using `bundle config unset gem.ci`."
467-
exit 1
468-
end
469-
end
470-
471457
def validate_rust_builder_rubygems_version
472458
if Gem::Version.new(rust_builder_required_rubygems_version) > Gem.rubygems_version
473459
Bundler.ui.error "Your RubyGems version (#{Gem.rubygems_version}) is too old to build Rust extension. Please update your RubyGems using `gem update --system` or any other way and try again."

bundler/spec/commands/newgem_spec.rb

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -956,24 +956,6 @@ def create_temporary_dir(dir)
956956
end
957957
end
958958

959-
context "--ci set to travis" do
960-
it "generates a GitHub Actions config file" do
961-
bundle "gem #{gem_name} --ci=travis", raise_on_error: false
962-
expect(err).to include("Support for Travis CI was removed from gem skeleton generator.")
963-
964-
expect(bundled_app("#{gem_name}/.travis.yml")).to_not exist
965-
end
966-
end
967-
968-
context "--ci set to travis" do
969-
it "generates a GitHub Actions config file" do
970-
bundle "gem #{gem_name} --ci=travis", raise_on_error: false
971-
expect(err).to include("Support for Travis CI was removed from gem skeleton generator.")
972-
973-
expect(bundled_app("#{gem_name}/.travis.yml")).to_not exist
974-
end
975-
end
976-
977959
context "--ci set to github" do
978960
it "generates a GitHub Actions config file" do
979961
bundle "gem #{gem_name} --ci=github"
@@ -1024,18 +1006,6 @@ def create_temporary_dir(dir)
10241006
end
10251007
end
10261008

1027-
context "gem.ci setting set to travis" do
1028-
it "errors with friendly message" do
1029-
bundle "config set gem.ci travis"
1030-
bundle "gem #{gem_name}", raise_on_error: false
1031-
1032-
expect(err).to include("Support for Travis CI was removed from gem skeleton generator,")
1033-
expect(err).to include("bundle config unset gem.ci")
1034-
1035-
expect(bundled_app("#{gem_name}/.travis.yml")).to_not exist
1036-
end
1037-
end
1038-
10391009
context "gem.ci setting set to github" do
10401010
it "generates a GitHub Actions config file" do
10411011
bundle "config set gem.ci github"

test/rubygems/test_gem_commands_setup_command.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ def setup
3131
bundler/lib/bundler/man/gemfile.5
3232
bundler/lib/bundler/man/gemfile.5.ronn
3333
bundler/lib/bundler/templates/.circleci/config.yml
34-
bundler/lib/bundler/templates/.travis.yml
3534
]
3635

3736
create_dummy_files(filelist)
@@ -195,7 +194,6 @@ def test_install_lib
195194
assert_path_exist File.join(dir, "bundler/b.rb")
196195

197196
assert_path_exist File.join(dir, "bundler/templates/.circleci/config.yml")
198-
assert_path_exist File.join(dir, "bundler/templates/.travis.yml")
199197
end
200198
end
201199

0 commit comments

Comments
 (0)