Skip to content

Commit 3d0a916

Browse files
Merge pull request #8319 from rubygems/deivid-rodriguez/better-test-output
Don't print a bunch of blank lines when setting up dependencies
2 parents bccc924 + 72316ed commit 3d0a916

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

bundler/spec/support/rubygems_ext.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,8 +150,9 @@ def install_gems(gemfile, path = nil)
150150
ENV["BUNDLE_PATH__SYSTEM"] = "true"
151151
end
152152

153-
puts `#{Gem.ruby} #{File.expand_path("support/bundle.rb", Path.spec_dir)} install --quiet`
154-
raise unless $?.success?
153+
# We don't use `Open3` here because it does not work on JRuby + Windows
154+
output = `#{Gem.ruby} #{File.expand_path("support/bundle.rb", Path.spec_dir)} install`
155+
raise output unless $?.success?
155156
ensure
156157
if path
157158
ENV["BUNDLE_PATH"] = old_path

doc/rubygems/CONTRIBUTING.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,21 +70,19 @@ And to run an individual test method named `test_default` within a test file, yo
7070

7171
### Running bundler tests
7272

73-
Everything needs to be run from the `bundler/` subfolder.
74-
7573
To setup bundler tests:
7674

7775
bin/rake spec:parallel_deps
7876

79-
To run the entire bundler test suite in parallel (it takes a while):
77+
To run the entire bundler test suite in parallel (it takes a while), run the following from the `bundler/` subfolder:
8078

8179
bin/parallel_rspec
8280

8381
There are some realworld higher level specs run in CI, but not run by `bin/parallel_rspec`. You can run those with:
8482

8583
bin/rake spec:realworld
8684

87-
To run an individual test file location for example in `spec/install/gems/standalone_spec.rb` you can use:
85+
To run an individual test file location for example in `spec/install/gems/standalone_spec.rb` you can use the following from the `bundler/` subfolder:
8886

8987
bin/rspec spec/install/gems/standalone_spec.rb
9088

0 commit comments

Comments
 (0)