Improve tests after review

Author: trinistr

library/tempfile/create_spec.rb

@@ -22,33 +22,47 @@
     @tempfile.path.should_not == "#{Dir.tmpdir}/"
   end
 
-  it "returns a writable, readable file" do
+  it "returns file in w+ mode" do
     @tempfile = Tempfile.create
-    File.writable?(@tempfile.path).should be_true
     @tempfile << "Test!\nMore test!"
-    @tempfile.seek(0)
-    @tempfile.gets.should == "Test!\n"
+    @tempfile.rewind
+    @tempfile.read.should == "Test!\nMore test!"
+
+    # Not "a+" mode, which would write at the end of the file.
+    @tempfile.rewind
+    @tempfile.print "Trust"
+    @tempfile.rewind
+    @tempfile.read.should == "Trust\nMore test!"
   end
 
   platform_is_not :windows do
-    it "returns a private file" do
+    it "returns a private, readable and writable file" do
       @tempfile = Tempfile.create
-      @tempfile.stat.mode.to_s(8).should.end_with?("600")
+      stat = @tempfile.stat
+      stat.should.readable?
+      stat.should.writable?
+      stat.should_not.executable?
+      stat.should_not.world_readable?
+      stat.should_not.world_writable?
     end
   end
 
   platform_is :windows do
-    it "returns a public file" do
+    it "returns a public, readable and writable file" do
       @tempfile = Tempfile.create
-      @tempfile.stat.mode.to_s(8).should.end_with?("666")
+      stat = @tempfile.stat
+      stat.should.readable?
+      stat.should.writable?
+      stat.should_not.executable?
+      stat.should.world_readable?
+      stat.should.world_writable?
     end
   end
 
   context "when called with a block" do
     it "returns the value of the block" do
       value = Tempfile.create do |tempfile|
         tempfile << "Test!"
-        @tempfile = tempfile
         "return"
       end
       value.should == "return"
@@ -58,11 +72,11 @@
       Tempfile.create do |tempfile|
         @tempfile = tempfile
         @tempfile.should_not.closed?
-        File.file?(@tempfile.path).should be_true
+        File.exist?(@tempfile.path).should be_true
       end
 
       @tempfile.should.closed?
-      File.file?(@tempfile.path).should be_false
+      File.exist?(@tempfile.path).should be_false
     end
   end
 
@@ -73,21 +87,29 @@
       @tempfile.path.should_not == "#{Dir.tmpdir}/create_spec"
     end
 
+    it "uses an array of one String as a prefix for the filename" do
+      @tempfile = Tempfile.create(["create_spec"])
+      @tempfile.path.should.start_with?("#{Dir.tmpdir}/create_spec")
+      @tempfile.path.should_not == "#{Dir.tmpdir}/create_spec"
+    end
+
     it "uses an array of two Strings as a prefix and suffix for the filename" do
       @tempfile = Tempfile.create(["create_spec", ".temp"])
       @tempfile.path.should.start_with?("#{Dir.tmpdir}/create_spec")
       @tempfile.path.should.end_with?(".temp")
     end
 
-    it "ignores more than two elements in the array" do
+    it "ignores excessive array elements after the first two" do
       @tempfile = Tempfile.create(["create_spec", ".temp", :".txt"])
       @tempfile.path.should.start_with?("#{Dir.tmpdir}/create_spec")
       @tempfile.path.should.end_with?(".temp")
     end
 
     it "raises ArgumentError if passed something else than a String or an array of Strings" do
-      -> { Tempfile.create(:temp) }.should raise_error(ArgumentError, "unexpected prefix: :temp")
+      -> { Tempfile.create(:create_spec) }.should raise_error(ArgumentError, "unexpected prefix: :create_spec")
+      -> { Tempfile.create([:create_spec]) }.should raise_error(ArgumentError, "unexpected prefix: :create_spec")
       -> { Tempfile.create(["create_spec", :temp]) }.should raise_error(ArgumentError, "unexpected suffix: :temp")
+
     end
   end