Skip to content

Commit 9e3db14

Browse files
committed
Deprecate constant Id
`$Id$` is for RCS, CVS, and SVN; no information with GIT.
1 parent abacbbf commit 9e3db14

File tree

3 files changed

+2
-5
lines changed

3 files changed

+2
-5
lines changed

ext/jruby/org/jruby/ext/strscan/RubyStringScanner.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ public static RubyClass createScannerClass(final Ruby runtime) {
100100
RubyString id = runtime.newString("$Id$");
101101
id.setFrozen(true);
102102
scannerClass.setConstant(context, "Id", id);
103+
scannerClass.deprecateConstant(context, "Id");
103104

104105
scannerClass.defineAnnotatedMethods(RubyStringScanner.class);
105106

ext/strscan/strscan.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2226,6 +2226,7 @@ Init_strscan(void)
22262226
tmp = rb_str_new2("$Id$");
22272227
rb_obj_freeze(tmp);
22282228
rb_const_set(StringScanner, rb_intern("Id"), tmp);
2229+
rb_deprecate_constant(StringScanner, "Id");
22292230

22302231
rb_define_alloc_func(StringScanner, strscan_s_allocate);
22312232
rb_define_private_method(StringScanner, "initialize", strscan_initialize, -1);

test/strscan/test_stringscanner.rb

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -107,11 +107,6 @@ def test_const_Version
107107
assert_equal(true, StringScanner::Version.frozen?)
108108
end
109109

110-
def test_const_Id
111-
assert_instance_of(String, StringScanner::Id)
112-
assert_equal(true, StringScanner::Id.frozen?)
113-
end
114-
115110
def test_inspect
116111
str = 'test string'.dup
117112
s = create_string_scanner(str, false)

0 commit comments

Comments
 (0)