Add test for SHA sum lengths

Check for wrong SHA sum lengths in release posts, an error that
happens from time to time (mainly truncated or wrapped SHA512).

Author: stomar

lib/linter.rb

@@ -82,6 +82,13 @@ def check
         errors[doc] << "missing translator variable"  if doc.translator_missing?
         errors[doc] << "missing date variable"  if doc.date_missing?
       end
+
+      if doc.release_post?
+        errors[doc] << "invalid SHA1 length"  if doc.sha1_length_invalid?
+        errors[doc] << "invalid SHA256 length"  if doc.sha256_length_invalid?
+        errors[doc] << "invalid SHA512 length"  if doc.sha512_length_invalid?
+      else
+      end
     end
   end
 

lib/linter/document.rb

@@ -19,6 +19,10 @@ def post?
       filename.match? %r{/_posts/}
     end
 
+    def release_post?
+      post? && filename.match?(%r{released\.md})
+    end
+
     # posts from before the migration to the Jekyll site
     # (they follow different rules; e.g. they have no YAML date variable,
     # filenames of translations differ from original `en' post, ...)
@@ -91,6 +95,27 @@ def trailing_whitespace?
       content.match?(/ $/)
     end
 
+    def sha1_length_invalid?
+      matchdata = content.match(/SHA1: *(?<sha>[0-9a-f]*)/)
+      return nil  unless matchdata
+
+      matchdata[:sha].size != 40
+    end
+
+    def sha256_length_invalid?
+      matchdata = content.match(/SHA256: *(?<sha>[0-9a-f]*)/)
+      return nil  unless matchdata
+
+      matchdata[:sha].size != 64
+    end
+
+    def sha512_length_invalid?
+      matchdata = content.match(/SHA512: *(?<sha>[0-9a-f]*)/)
+      return nil  unless matchdata
+
+      matchdata[:sha].size != 128
+    end
+
     private
 
     def read_yaml_and_content(filename)

test/md_errors/en/_posts/2019-01-01-invalid-sha1-length-released.md

@@ -0,0 +1,16 @@
+---
+layout: news_post
+title: "Release Post"
+author: "stomar"
+translator:
+date: 2019-01-01 12:00:00 +0000
+lang: en
+---
+
+Content
+
+Sums, SHA1 too short
+
+    SHA1:    abcdef78901234567890
+    SHA256:  abcdef7890123456789012345678901234567890123456789012345678901234
+    SHA512:  abcdef78901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678

test/md_errors/en/_posts/2019-01-02-invalid-sha256-length-released.md

@@ -0,0 +1,16 @@
+---
+layout: news_post
+title: "Release Post"
+author: "stomar"
+translator:
+date: 2019-01-02 12:00:00 +0000
+lang: en
+---
+
+Content
+
+Sums, SHA256 too long
+
+    SHA1:    abcdef7890123456789012345678901234567890
+    SHA256:  abcdef7890123456789012345678901234567890123456789012345678901234567890
+    SHA512:  abcdef78901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678

test/md_errors/en/_posts/2019-01-03-invalid-sha512-length-released.md

@@ -0,0 +1,17 @@
+---
+layout: news_post
+title: "Release Post"
+author: "stomar"
+translator:
+date: 2019-01-03 12:00:00 +0000
+lang: en
+---
+
+Content
+
+Sums, SHA512 wrapped
+
+    SHA1:    abcdef7890123456789012345678901234567890
+    SHA256:  abcdef7890123456789012345678901234567890123456789012345678901234
+    SHA512:  abcdef789012345678901234567890123456789012345678901234567890
+12345678901234567890123456789012345678901234567890123456789012345678

test/md_ok/en/_posts/2019-01-01-ruby-with-sha-sums-released.md

@@ -0,0 +1,16 @@
+---
+layout: news_post
+title: "Release Post"
+author: "stomar"
+translator:
+date: 2019-01-01 12:00:00 +0000
+lang: en
+---
+
+Content
+
+Sums:
+
+    SHA1:    abcdef7890123456789012345678901234567890
+    SHA256:  abcdef7890123456789012345678901234567890123456789012345678901234
+    SHA512:  abcdef78901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678

test/md_ok/en/_posts/2019-01-01-ruby-without-sha512-sum-released.md

@@ -0,0 +1,15 @@
+---
+layout: news_post
+title: "Release Post"
+author: "stomar"
+translator:
+date: 2019-01-01 12:00:00 +0000
+lang: en
+---
+
+Content
+
+Sums:
+
+    SHA1:    abcdef7890123456789012345678901234567890
+    SHA256:  abcdef7890123456789012345678901234567890123456789012345678901234

test/output_errors.txt

@@ -58,3 +58,9 @@ en/_posts/2018-01-14-date-variable-wrong-offset.md
   date variable with wrong time zone offset (not +0000)
 en/_posts/2018-01-15-date-mismatch.md
   filename not matching date variable
+en/_posts/2019-01-01-invalid-sha1-length-released.md
+  invalid SHA1 length
+en/_posts/2019-01-02-invalid-sha256-length-released.md
+  invalid SHA256 length
+en/_posts/2019-01-03-invalid-sha512-length-released.md
+  invalid SHA512 length