test: add support for changing target parser

Author: kou

.github/workflows/test.yml

@@ -38,4 +38,9 @@ jobs:
         with:
           ruby-version: ${{ matrix.ruby }}
           bundler-cache: true # 'bundle install' and cache gems
-      - run: bundle exec rake
+      - name: Test with REXML
+        run: bundle exec rake
+      - name: Test with libxml
+        env:
+          XMLRPC_PARSER: libxml
+        run: bundle exec rake

test/helper.rb

@@ -0,0 +1,12 @@
+require "test-unit"
+
+module TestHelper
+  def parser
+    case ENV["XMLRPC_PARSER"]
+    when "libxml"
+      XMLRPC::XMLParser::LibXMLStreamParser.new
+    else
+      XMLRPC::XMLParser::REXMLStreamParser.new
+    end
+  end
+end

test/test_client.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: false
-require 'test/unit'
+
+require_relative 'helper'
+
 require 'xmlrpc/client'
 require 'net/http'
 begin
@@ -9,6 +11,8 @@
 
 module XMLRPC
   class ClientTest < Test::Unit::TestCase
+    include TestHelper
+
     module Fake
       class HTTP < Net::HTTP
         class << self
@@ -217,7 +221,7 @@ def test_request
         '/foo' => [ Fake::Response.new(fh, [['Content-Type', 'text/xml']]) ]
       }
 
-      client = fake_client(responses).new2 'http://example.org/foo'
+      client = fake_client(responses, 'http://example.org/foo')
 
       resp = client.call('wp.getUsersBlogs', 'tlo', 'omg')
 
@@ -239,7 +243,7 @@ def test_async_request
         '/foo' => [ Fake::Response.new(fh, [['Content-Type', 'text/xml']]) ]
       }
 
-      client = fake_client(responses).new2 'http://example.org/foo'
+      client = fake_client(responses, 'http://example.org/foo')
 
       resp = client.call_async('wp.getUsersBlogs', 'tlo', 'omg')
 
@@ -261,7 +265,7 @@ def test_application_xml_content_type
         '/foo' => [ Fake::Response.new(fh, [['Content-Type', 'application/xml']]) ]
       }
 
-      client = fake_client(responses).new2 'http://example.org/foo'
+      client = fake_client(responses, 'http://example.org/foo')
 
       resp = client.call('wp.getUsersBlogs', 'tlo', 'omg')
 
@@ -284,7 +288,7 @@ def test_bad_content_type
         '/foo' => [ Fake::Response.new(fh) ]
       }
 
-      client = fake_client(responses).new2 'http://example.org/foo'
+      client = fake_client(responses, 'http://example.org/foo')
 
       resp = client.call('wp.getUsersBlogs', 'tlo', 'omg')
 
@@ -304,7 +308,7 @@ def test_no_data
         '/foo' => [ Fake::Response.new(nil, [['Content-Type', 'text/xml']]) ]
       }
 
-      client = fake_client(responses).new2 'http://example.org/foo'
+      client = fake_client(responses, 'http://example.org/foo')
 
       assert_raise(RuntimeError.new("No data")) do
         client.call('wp.getUsersBlogs', 'tlo', 'omg')
@@ -318,7 +322,7 @@ def test_i8_tag
         '/foo' => [ Fake::Response.new(fh) ]
       }
 
-      client = fake_client(responses).new2 'http://example.org/foo'
+      client = fake_client(responses, 'http://example.org/foo')
 
       resp = client.call('wp.getUsersBlogs', 'tlo', 'omg')
 
@@ -348,10 +352,13 @@ def read filename
       File.read File.expand_path(File.join(__FILE__, '..', 'data', filename))
     end
 
-    def fake_client responses
-      Class.new(Fake::Client) {
+    def fake_client(responses, uri)
+      client_class = Class.new(Fake::Client) {
         define_method(:net_http) { |*_| Fake::HTTP.new(responses) }
       }
+      client = client_class.new2(uri)
+      client.set_parser(parser)
+      client
     end
   end
 end

test/test_server.rb

@@ -1,19 +1,22 @@
-# coding: utf-8
 # frozen_string_literal: true
 
-require 'test/unit'
+require_relative 'helper'
+
 require 'stringio'
 require 'xmlrpc/client'
 require 'xmlrpc/server'
 
 module TestXMLRPC
 class TestXMLRPCServer < Test::Unit::TestCase
+  include TestHelper
+
   def test_port
     s = nil
     begin
       stdout, $stdout = $stdout, StringIO.new
       stderr, $stderr = $stderr, StringIO.new
       s = XMLRPC::Server.new(0, '127.0.0.1', 1)
+      s.set_parser(parser)
     ensure
       $stdout = stdout
       $stderr = stderr
@@ -25,6 +28,7 @@ def test_port
 
     begin
       c = XMLRPC::Client.new('127.0.0.1', '/', s.port)
+      c.set_parser(parser)
       assert_equal(7, c.call('test.add', 3, 4))
     ensure
       s.shutdown