caching file_path teams on team_names_for_files

Author: perryqh

lib/code_ownership.rb

@@ -47,9 +47,7 @@ def for_file(file)
 
   sig { params(files: T::Array[String]).returns(T::Hash[String, T.nilable(CodeTeams::Team)]) }
   def team_names_for_files(files)
-    ::RustCodeOwners.team_names_for_files(files).transform_values do |team|
-      team ? CodeTeams.find(team[:team_name]) : nil
-    end
+    Private::TeamFinder.team_names_for_files(files)
   end
 
   sig { params(file: String).returns(T.nilable(T::Hash[Symbol, String])) }

lib/code_ownership/code_ownership.bundle

@@ -30,6 +30,16 @@ def for_file(file_path)
         FilePathTeamCache.get(file_path)
       end
 
+      sig { params(files: T::Array[String]).returns(T::Hash[String, T.nilable(CodeTeams::Team)]) }
+      def team_names_for_files(files)
+        ::RustCodeOwners.team_names_for_files(files).each_with_object({}) do |path_team, hash|
+          file_path, team = path_team
+          found_team = team ? CodeTeams.find(team[:team_name]) : nil
+          FilePathTeamCache.set(file_path, found_team)
+          hash[file_path] = found_team
+        end
+      end
+
       sig { params(klass: T.nilable(T.any(T::Class[T.anything], Module))).returns(T.nilable(::CodeTeams::Team)) }
       def for_class(klass)
         file_path = FilePathFinder.path_from_klass(klass)

lib/code_ownership/private/team_finder.rb

@@ -42,6 +42,16 @@
         it 'returns the correct team' do
           expect(subject).to eq({ 'packs/my_pack/owned_file.rb' => CodeTeams.find('Bar') })
         end
+        
+        context 'subsequent for_file utilizes cached team' do 
+          let(:files) { ['packs/my_pack/owned_file.rb', 'packs/my_pack/owned_file2.rb'] }
+          it 'returns the correct team' do
+            subject # caches paths -> teams
+            allow(RustCodeOwners).to receive(:for_file)
+            expect(described_class.for_file('packs/my_pack/owned_file.rb')).to eq(CodeTeams.find('Bar'))
+            expect(RustCodeOwners).to_not have_received(:for_file)
+          end
+        end
       end
 
       context 'when ownership is found but team is not found' do