edge cases

Author: perryqh

.gitignore

@@ -7,6 +7,7 @@
 /spec/reports/
 /tmp/
 /target/
+/vendor
 
 Gemfile.lock
 

Rakefile

@@ -5,4 +5,4 @@ GEMSPEC = Gem::Specification.load('code_ownership.gemspec')
 task build: 'pkg:ruby'
 
 # task default: %w[env:dev compile spec]
-task default: %w[env:dev compile]
+task default: %w[env:dev compile spec]

lib/code_ownership/code_ownership.bundle

@@ -61,6 +61,40 @@
         end
       end
     end
+
+    context 'with --skip-autocorrect' do
+      let(:argv) { ['validate', '--skip-autocorrect'] }
+
+      it 'passes autocorrect: false' do
+        expect(CodeOwnership).to receive(:validate!) do |args|
+          expect(args[:autocorrect]).to eq false
+          expect(args[:stage_changes]).to eq true
+        end
+        subject
+      end
+    end
+
+    context 'with --skip-stage' do
+      let(:argv) { ['validate', '--skip-stage'] }
+
+      it 'passes stage_changes: false' do
+        expect(CodeOwnership).to receive(:validate!) do |args|
+          expect(args[:autocorrect]).to eq true
+          expect(args[:stage_changes]).to eq false
+        end
+        subject
+      end
+    end
+
+    context 'with --help' do
+      let(:argv) { ['validate', '--help'] }
+
+      it 'shows help and exits' do
+        expect(CodeOwnership).not_to receive(:validate!)
+        expect(CodeOwnership::Cli).to receive(:puts).at_least(:once)
+        expect { subject }.to raise_error(SystemExit)
+      end
+    end
   end
 
   context 'for_team' do
@@ -82,6 +116,31 @@
       expect(CodeOwnership::Cli).to receive(:puts).with('# Code Ownership Report for `My Team` Team')
       subject
     end
+
+    context 'with no team provided' do
+      let(:argv) { ['for_team'] }
+
+      it 'raises argument error' do
+        expect { subject }.to raise_error("Please pass in one team. Use `#{described_class::EXECUTABLE} for_team --help` for more info")
+      end
+    end
+
+    context 'with multiple teams provided' do
+      let(:argv) { %w[for_team A B] }
+
+      it 'raises argument error' do
+        expect { subject }.to raise_error("Please pass in one team. Use `#{described_class::EXECUTABLE} for_team --help` for more info")
+      end
+    end
+
+    context 'with --help' do
+      let(:argv) { ['for_team', '--help'] }
+
+      it 'shows help and exits' do
+        expect(CodeOwnership::Cli).to receive(:puts).at_least(:once)
+        expect { subject }.to raise_error(SystemExit)
+      end
+    end
   end
 
   describe 'for_file' do
@@ -164,6 +223,28 @@ def initialize
         end
       end
     end
+
+    context 'when file is unowned' do
+      let(:argv) { ['for_file', 'app/services/unowned.rb'] }
+
+      it 'prints Unowned' do
+        allow(CodeOwnership).to receive(:for_file).and_return(nil)
+        expect(CodeOwnership::Cli).to receive(:puts).with(<<~MSG)
+          Team: Unowned
+          Team YML: Unowned
+        MSG
+        subject
+      end
+    end
+
+    context 'with --help' do
+      let(:argv) { ['for_file', '--help'] }
+
+      it 'shows help and exits' do
+        expect(CodeOwnership::Cli).to receive(:puts).at_least(:once)
+        expect { subject }.to raise_error(SystemExit)
+      end
+    end
   end
 
   describe 'using unknown command' do

spec/lib/code_ownership/cli_spec.rb

@@ -36,4 +36,48 @@ class TestClass; end # rubocop:disable Lint/ConstantDefinitionInBlock, Lint/Empt
       end
     end
   end
+
+  describe '.from_backtrace' do
+    subject(:files) { described_class.from_backtrace(backtrace).to_a }
+
+    context 'when backtrace is nil' do
+      let(:backtrace) { nil }
+
+      it 'returns an empty array' do
+        expect(files).to eq([])
+      end
+    end
+
+    context 'when backtrace is empty' do
+      let(:backtrace) { [] }
+
+      it 'returns an empty array' do
+        expect(files).to eq([])
+      end
+    end
+
+    context 'on Ruby < 3.4 backtrace format (backticks)' do
+      let(:backtrace) do
+        ["./app/models/user.rb:12:in `save'", "app/controllers/some_controller.rb:43:in `block (2 levels) in create'"]
+      end
+
+      it 'extracts file paths' do
+        expect(files).to include('app/models/user.rb', 'app/controllers/some_controller.rb')
+      end
+    end
+
+    context 'on Ruby >= 3.4 backtrace format (single quotes)' do
+      let(:backtrace) do
+        ["./app/models/user.rb:12:in 'save'", "app/controllers/some_controller.rb:43:in 'block (2 levels) in create'"]
+      end
+
+      it 'extracts file paths' do
+        if RUBY_VERSION >= '3.4.0'
+          expect(files).to include('app/models/user.rb', 'app/controllers/some_controller.rb')
+        else
+          skip 'Ruby version < 3.4 does not use single quote backtrace format'
+        end
+      end
+    end
+  end
 end

spec/lib/code_ownership/private/file_path_finder_spec.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+RSpec.describe CodeOwnership::Private::PackOwnershipValidator do
+  it 'permits the owner top-level key' do
+    expect(described_class.new.permitted_keys).to include('owner')
+  end
+end

spec/lib/code_ownership/private/permit_pack_owner_top_level_key_spec.rb

@@ -0,0 +1,50 @@
+# frozen_string_literal: true
+
+RSpec.describe CodeOwnership::Private::TeamFinder do
+  describe '.for_file' do
+    let(:file_path) { 'packs/my_pack/owned_file.rb' }
+
+    before do
+      create_non_empty_application
+    end
+
+    it 'caches positive results' do
+      allow(RustCodeOwners).to receive(:for_file).with(file_path)
+        .and_return({ team_name: 'Bar' }, nil)
+
+      first = described_class.for_file(file_path)
+      second = described_class.for_file(file_path)
+
+      expect(first).to eq(CodeTeams.find('Bar'))
+      expect(second).to eq(CodeTeams.find('Bar'))
+      expect(CodeOwnership::Private::FilePathTeamCache.cached?(file_path)).to be true
+    end
+
+    it 'does not cache when rust returns nil' do
+      allow(RustCodeOwners).to receive(:for_file).with(file_path).and_return(nil)
+
+      expect(described_class.for_file(file_path)).to be_nil
+      expect(CodeOwnership::Private::FilePathTeamCache.cached?(file_path)).to be false
+    end
+
+    it 'caches nil when team_name is nil' do
+      allow(RustCodeOwners).to receive(:for_file).with(file_path).and_return({ team_name: nil })
+
+      expect(described_class.for_file(file_path)).to be_nil
+      expect(CodeOwnership::Private::FilePathTeamCache.cached?(file_path)).to be true
+      expect(CodeOwnership::Private::FilePathTeamCache.get(file_path)).to be_nil
+    end
+  end
+
+  describe '.for_backtrace' do
+    it 'returns nil for nil backtrace' do
+      expect(described_class.for_backtrace(nil)).to be_nil
+    end
+  end
+
+  describe '.first_owned_file_for_backtrace' do
+    it 'returns nil for nil backtrace' do
+      expect(described_class.first_owned_file_for_backtrace(nil)).to be_nil
+    end
+  end
+end

spec/lib/code_ownership/private/team_finder_spec.rb

@@ -127,6 +127,22 @@
         expect(subject).to be_nil
       end
     end
+
+    context 'with unknown owner' do
+      let(:raw_hash) { { 'owner' => 'Does Not Exist' } }
+
+      it 'raises helpful error' do
+        expect { subject }.to raise_error(StandardError, /Could not find team with name:/)
+      end
+    end
+
+    context 'with empty owner string' do
+      let(:raw_hash) { { 'owner' => '' } }
+
+      it 'raises helpful error' do
+        expect { subject }.to raise_error(StandardError, /Could not find team with name:/)
+      end
+    end
   end
 
   describe '.for_backtrace' do
@@ -151,6 +167,12 @@
         end
       end
     end
+
+    context 'with nil backtrace' do
+      it 'returns nil' do
+        expect(described_class.for_backtrace(nil)).to be_nil
+      end
+    end
   end
 
   describe '.first_owned_file_for_backtrace' do
@@ -183,5 +205,11 @@
         end
       end
     end
+
+    context 'with nil backtrace' do
+      it 'returns nil' do
+        expect(described_class.first_owned_file_for_backtrace(nil)).to be_nil
+      end
+    end
   end
 end