rubocop fixes

Author: martinemde

.rubocop.yml

@@ -27,6 +27,18 @@ AllCops:
 Gemspec/RequireMFA:
   Enabled: false
 
+# Allow extend self pattern
+Style/ModuleFunction:
+  Enabled: false
+
+# Allow expect_any_instance_of in tests for specific testing patterns
+RSpec/AnyInstance:
+  Enabled: false
+
+# Allow after(:all) for necessary cleanup
+RSpec/BeforeAfterAll:
+  Enabled: false
+
 # This leads to code that is not very readable at times (very long lines)
 Layout/ArgumentAlignment:
   Enabled: false
@@ -124,6 +136,10 @@ Style/NegatedIf:
 Style/RedundantCondition:
   Enabled: false
 
+Style/StringLiterals:
+  EnforcedStyle: single_quotes
+  Enabled: true
+
 # This cop is annoying with typed configuration
 Style/TrivialAccessors:
   Enabled: false

Gemfile

@@ -1,13 +1,13 @@
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
 gemspec
 
-gem "debug"
-gem "packwerk"
-gem "railties"
-gem "rake"
-gem "rspec"
-gem "rubocop"
-gem "rubocop-gusto", "~> 10.0"
-gem "sorbet"
-gem "tapioca"
+gem 'debug'
+gem 'packwerk'
+gem 'railties'
+gem 'rake'
+gem 'rspec'
+gem 'rubocop'
+gem 'rubocop-gusto', '~> 10.0'
+gem 'sorbet'
+gem 'tapioca'

bin/rubocop

@@ -8,9 +8,9 @@
 # this file is here to facilitate running it.
 #
 
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../Gemfile', __dir__)
 
-require "rubygems"
-require "bundler/setup"
+require 'rubygems'
+require 'bundler/setup'
 
-load Gem.bin_path("rubocop", "rubocop")
+load Gem.bin_path('rubocop', 'rubocop')

bin/tapioca

@@ -0,0 +1,16 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'tapioca' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../Gemfile', __dir__)
+
+require 'rubygems'
+require 'bundler/setup'
+
+load Gem.bin_path('tapioca', 'tapioca')

lib/code_ownership.rb

@@ -2,7 +2,6 @@
 
 # typed: strict
 
-require 'set'
 require 'code_teams'
 require 'sorbet-runtime'
 require 'json'
@@ -17,7 +16,7 @@
 end
 
 module CodeOwnership
-  module_function
+  extend self
 
   extend T::Sig
   extend T::Helpers

lib/code_ownership/cli.rb

@@ -56,12 +56,12 @@ def self.validate!(argv)
       parser.parse!(args)
 
       files = if options[:diff]
-                ENV.fetch('CODEOWNERS_GIT_STAGED_FILES') { `git diff --staged --name-only` }.split("\n").select do |file|
-                  File.exist?(file)
-                end
-              else
-                nil
-              end
+        ENV.fetch('CODEOWNERS_GIT_STAGED_FILES') { %x(git diff --staged --name-only) }.split("\n").select do |file|
+          File.exist?(file)
+        end
+      else
+        nil
+      end
 
       CodeOwnership.validate!(
         files: files,
@@ -107,7 +107,7 @@ def self.for_file(argv)
       if options[:json]
         json = {
           team_name: team_name,
-          team_yml: team_yml
+          team_yml: team_yml,
         }
 
         puts json.to_json
@@ -121,7 +121,7 @@ def self.for_file(argv)
 
     def self.for_team(argv)
       parser = OptionParser.new do |opts|
-        opts.banner = 'Usage: bin/codeownership for_team \'Team Name\''
+        opts.banner = "Usage: bin/codeownership for_team 'Team Name'"
 
         opts.on('--help', 'Shows this prompt') do
           puts opts

lib/code_ownership/configuration.rb

@@ -3,6 +3,7 @@
 module CodeOwnership
   class Configuration < T::Struct
     extend T::Sig
+
     DEFAULT_JS_PACKAGE_PATHS = T.let(['**/'], T::Array[String])
 
     const :owned_globs, T::Array[String]
@@ -31,7 +32,7 @@ def self.fetch
         skip_codeowners_validation: config_hash.fetch('skip_codeowners_validation', false),
         raw_hash: config_hash,
         require_github_teams: config_hash.fetch('require_github_teams', false),
-        codeowners_path: config_hash.fetch('codeowners_path', '.github'),
+        codeowners_path: config_hash.fetch('codeowners_path', '.github')
       )
     end
 

lib/code_ownership/mapper.rb

@@ -32,7 +32,8 @@ def all
       abstract.params(file: String)
         .returns(T.nilable(::CodeTeams::Team))
     end
-    def map_file_to_owner(file); end
+    def map_file_to_owner(file)
+    end
 
     #
     # This should be fast when run with MANY files
@@ -41,21 +42,25 @@ def map_file_to_owner(file); end
       abstract.params(files: T::Array[String])
         .returns(T::Hash[String, ::CodeTeams::Team])
     end
-    def globs_to_owner(files); end
+    def globs_to_owner(files)
+    end
 
     #
     # This should be fast when run with MANY files
     #
     sig do
       abstract.params(cache: GlobsToOwningTeamMap, files: T::Array[String]).returns(GlobsToOwningTeamMap)
     end
-    def update_cache(cache, files); end
+    def update_cache(cache, files)
+    end
 
     sig { abstract.returns(String) }
-    def description; end
+    def description
+    end
 
     sig { abstract.void }
-    def bust_caches!; end
+    def bust_caches!
+    end
 
     sig { returns(Private::GlobCache) }
     def self.to_glob_cache

lib/code_ownership/private/codeowners_file.rb

@@ -64,10 +64,10 @@ def self.expected_contents_lines
             # 1) It allows the CODEOWNERS file to be used as a cache for validations
             # 2) It allows users to specifically see what their team will not be notified about.
             entry = if ignored_teams.include?(code_team.name)
-                      "# /#{path} #{team_mapping}"
-                    else
-                      "/#{path} #{team_mapping}"
-                    end
+              "# /#{path} #{team_mapping}"
+            else
+              "/#{path} #{team_mapping}"
+            end
             ownership_entries << entry
           end
 
@@ -99,7 +99,7 @@ def self.expected_contents_lines
           *header.split("\n"),
           '', # For line between header and codeowners_file_lines
           *codeowners_file_lines,
-          '' # For end-of-file newline
+          '', # For end-of-file newline
         ]
       end
 
@@ -156,7 +156,7 @@ def self.to_glob_cache
             # The codeowners file stores paths relative to the root of directory
             # Since a `/` means root of the file system from the perspective of ruby,
             # we remove that beginning slash so we can correctly glob the files out.
-            normalized_line = line.gsub(/^# /, '').gsub(%r{^/}, '')
+            normalized_line = line.delete_prefix('# ').delete_prefix('/')
             split_line = normalized_line.split
             # Most lines will be in the format: /path/to/file my-github-team
             # This will skip over lines that are not of the correct form

lib/code_ownership/private/extension_loader.rb

@@ -8,6 +8,7 @@ module Private
     module ExtensionLoader
       class << self
         extend T::Sig
+
         sig { params(require_directive: String).void }
         def load(require_directive)
           # We want to transform the require directive to behave differently